Re: [PATCH v2] Make display_lines output a diff

Hi Daniel, Ramkumar Ramachandra writes: > Daniel Shahaf writes: > > I suggest > > > > fromfile="EXPECTED %s" % label, > > tofile="ACTUAL %s" % label, > > Do I get a +1 for this? I just got one from Bert. Committed in r979710. Thanks. -- Ram

Re: [PATCH v2] Make display_lines output a diff

Hi Daniel, Daniel Shahaf writes: > I suggest > > fromfile="EXPECTED %s" % label, > tofile="ACTUAL %s" % label, Do I get a +1 for this? [[[ * subversion/tests/cmdline/svntest/verify.py (display_lines): Improve diff output by displaying `message` along with the header. Suggested

Re: [PATCH v2] Make display_lines output a diff

Stefan Sperling wrote on Mon, Jul 26, 2010 at 16:05:23 +0200: > On Mon, Jul 26, 2010 at 07:07:12PM +0530, Ramkumar Ramachandra wrote: > > [[[ > > * subversion/tests/cmdline/svntest/verify.py > > (display_lines): Additionally print unified diff output using Python > > difflib.unified_diff. > > ]

Re: [PATCH v2] Make display_lines output a diff

On Mon, Jul 26, 2010 at 07:07:12PM +0530, Ramkumar Ramachandra wrote: > [[[ > * subversion/tests/cmdline/svntest/verify.py > (display_lines): Additionally print unified diff output using Python > difflib.unified_diff. > ]]] +1 > > Index: subversion/tests/cmdline/svntest/verify.py > =

Re: [PATCH v2] Make display_lines output a diff

[[[ * subversion/tests/cmdline/svntest/verify.py (display_lines): Additionally print unified diff output using Python difflib.unified_diff. ]]] Index: subversion/tests/cmdline/svntest/verify.py === --- subversion/tests/cmdline/svn

Re: [PATCH v2] Make display_lines output a diff

On Mon, Jul 26, 2010 at 05:33:20PM +0530, Ramkumar Ramachandra wrote: > Hi Stefan, > > Stefan Sperling writes: > > Do all tests pass with it? > > Yes, they do. I ran `make check` and checked. I'm running it once > more, just in case. That's not neccessary. Your patch and the new diff output look

Re: [PATCH v2] Make display_lines output a diff

Hi Stefan, Stefan Sperling writes: > Do all tests pass with it? Yes, they do. I ran `make check` and checked. I'm running it once more, just in case. Thanks. -- Ram

Re: [PATCH v2] Make display_lines output a diff

On Mon, Jul 26, 2010 at 05:21:28PM +0530, Ramkumar Ramachandra wrote: > Hi, > > Ramkumar Ramachandra writes: > > Hi, > > > > Instead of spawning diff, I used difflib in Python. Here's the > > result. I need a +1 to commit this since it's outside my area. > > Is this patch alright? Do all tests

Re: [PATCH v2] Make display_lines output a diff

Hi, Ramkumar Ramachandra writes: > Hi, > > Instead of spawning diff, I used difflib in Python. Here's the > result. I need a +1 to commit this since it's outside my area. Is this patch alright? Thanks. -- Ram

[PATCH v2] Make display_lines output a diff

Hi, Instead of spawning diff, I used difflib in Python. Here's the result. I need a +1 to commit this since it's outside my area. Thanks. -- Ram [[[ * subversion/tests/cmdline/svntest/verify.py (display_lines): Use Python difflib to output a context diff instead of printing actual and expec