[Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-03 Thread Stefan Fuhrmann
Hi there, after stumbling twice over this issue, I ran grep and found that the current usage of svn_tristate_t does not depend on the actual numerical values used for its states. Therefore, I propose to define svn_tristate_false equal to FALSE and svn_tristate_true equal to TRUE. That way, we ca

RE: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: donderdag 4 november 2010 0:21 > To: Subversion Development > Subject: [Patch] Make svn_tristate_t compatible with svn_boolean_t > > Hi there, > > after stumbling twice

RE: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
Bert Huijben wrote: > > -Original Message- > > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > > after stumbling twice over this issue, I ran grep > > and found that the current usage of svn_tristate_t > > does not depend on the actual numerical values > > used for its states.

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04, Stefan Fuhrmann wrote: > Hi there, > > after stumbling twice over this issue, I ran grep > and found that the current usage of svn_tristate_t > does not depend on the actual numerical values > used for its states. > > Therefore, I propose to define svn_tristate_false > equal t

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: > On Thu, 2010-11-04, Stefan Fuhrmann wrote: > > Hi there, > > > > after stumbling twice over this issue, I ran grep > > and found that the current usage of svn_tristate_t > > does not depend on the actual numerical values > > used for its stat

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: > On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: >> On Thu, 2010-11-04, Stefan Fuhrmann wrote: >> > Hi there, >> > >> > after stumbling twice over this issue, I ran grep >> > and found that the current usage of svn_tristate_t >> > does not

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 6:51 AM, Julian Foad wrote: > On Thu, 2010-11-04, Stefan Fuhrmann wrote: >> Hi there, >> >> after stumbling twice over this issue, I ran grep >> and found that the current usage of svn_tristate_t >> does not depend on the actual numerical values >> used for its states. >> >>

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04 at 07:45 -0500, Hyrum K. Wright wrote: > On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: > > On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: > >> On Thu, 2010-11-04, Stefan Fuhrmann wrote: > >> > Hi there, > >> > > >> > after stumbling twice over this issue, I ran grep

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-07 Thread Stefan Fuhrmann
On 04.11.2010 13:47, Hyrum K. Wright wrote: On Thu, Nov 4, 2010 at 6:51 AM, Julian Foad wrote: On Thu, 2010-11-04, Stefan Fuhrmann wrote: Hi there, after stumbling twice over this issue, I ran grep and found that the current usage of svn_tristate_t does not depend on the actual numerical valu

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-08 Thread Julian Foad
On Sun, 2010-11-07, Stefan Fuhrmann wrote: [...] > Thanks all for the replies. Here is how I see it plus > a couple of things I discovered in the meantime. > > * general consensus: overlapping definitions with >inconsistent meaning are bad. > * enums are always compatible with ints, so we can'

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-08 Thread Greg Stein
On Thu, Nov 4, 2010 at 08:45, Hyrum K. Wright wrote: > On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: >... >> Having said all that, +1 on removing the gratuitous inconsistency by >> applying this patch. >> >> Committed r1030909. > > Gah.  Can we please wait a little bit longer on this kind of

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-09 Thread Daniel Shahaf
I would +1 everything you said... if Julian had changed svn_boolean_t. He changed svn_tristate_t, which is used exactly once in trunk, so I don't see the need to be as careful with it. The caveat? This assumes that --- as we ought to --- we not act on feedback differently because it comes after

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-10 Thread Greg Stein
It is used *once* ?! Bleh. Then I'd ask why we even have the type, especially why does it exist in svn_types.h. Your other points: quite fair. I assumed tristate_t was much more important due to its placement in svn_types. Cheers, -g On Tue, Nov 9, 2010 at 12:15, Daniel Shahaf wrote: > I would

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-11 Thread Julian Foad
On Wed, 2010-11-10, Greg Stein wrote: > It is used *once* ?! > > Bleh. Then I'd ask why we even have the type, especially why does it > exist in svn_types.h. I wondered the same. The answer appears to be that 'svn_log_changed_path2_t' (which was added to svn_types.h in 1.6) has now been extended