Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-28 Thread Ivan Zhakov
On Fri, Jun 21, 2013 at 1:51 PM, Greg Stein wrote: > On Fri, Jun 21, 2013 at 5:34 AM, Branko Čibej wrote: >> On 20.06.2013 17:27, Ivan Zhakov wrote: >>... >>> Also please believe that all my technical thoughts are fair and >>> related to technical issues only. My veto above is a technical veto. >

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-21 Thread Greg Stein
On Fri, Jun 21, 2013 at 5:34 AM, Branko Čibej wrote: > On 20.06.2013 17:27, Ivan Zhakov wrote: >... >> Also please believe that all my technical thoughts are fair and >> related to technical issues only. My veto above is a technical veto. > > Yep, it was. And I still maintain it's invalid, or at l

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-21 Thread Branko Čibej
On 20.06.2013 17:27, Ivan Zhakov wrote: > Mark, > > Wearing my VisualSVN CTO hat: > VisualSVN is a commercial company. And CollabNET is a commercial > company. That's not a surprise. > > And it's not a surprise that VisualSVN Server authentication works > fine after upgrade to Subversion 1.8. We ha

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Lieven Govaerts
On Thu, Jun 20, 2013 at 5:27 PM, Ivan Zhakov wrote: > Mark, > .. > Also please believe that all my technical thoughts are fair and > related to technical issues only. My veto above is a technical veto. I personally never doubted this based on your first mail, but that's just because I know serf a

RE: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Bert Huijben
From: kmra...@rockwellcollins.com [mailto:kmra...@rockwellcollins.com] > > Did you read my email above? Let me explain again. Server advertises > > supported authentication schemes, for example Microsoft IIS: > > [[[ > > C: GET / HTTP/1.1 > > S: HTTP/1.1 401 Authorization Required > > S: WWW-Authe

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Mark Phippard
On Thu, Jun 20, 2013 at 11:27 AM, Ivan Zhakov wrote: > Mark, > > Wearing my VisualSVN CTO hat: > VisualSVN is a commercial company. And CollabNET is a commercial > company. That's not a surprise. > > And it's not a surprise that VisualSVN Server authentication works > fine after upgrade to Subvers

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread kmradke
> Did you read my email above? Let me explain again. Server advertises > supported authentication schemes, for example Microsoft IIS: > [[[ > C: GET / HTTP/1.1 > S: HTTP/1.1 401 Authorization Required > S: WWW-Authenticate: NTLM > S: WWW-Authenticate: Negotiate > S: WWW-Authenticate: Basic > ]]] >

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Ivan Zhakov
Mark, Wearing my VisualSVN CTO hat: VisualSVN is a commercial company. And CollabNET is a commercial company. That's not a surprise. And it's not a surprise that VisualSVN Server authentication works fine after upgrade to Subversion 1.8. We have spent months with testing and debugging. It will be

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Stefan Sperling
On Thu, Jun 20, 2013 at 04:24:14PM +0200, Branko Čibej wrote: > On 20.06.2013 16:00, Mark Phippard wrote: > > On Thu, Jun 20, 2013 at 9:52 AM, Ivan Zhakov wrote: > > I fail to see how you can justify a veto here. > > I have to agree. The veto is fine on aesthetic grounds but kind of fails > to ta

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Branko Čibej
On 20.06.2013 16:00, Mark Phippard wrote: > On Thu, Jun 20, 2013 at 9:52 AM, Ivan Zhakov wrote: >> On Thu, Jun 20, 2013 at 5:44 PM, Mark Phippard wrote: >>> On Thu, Jun 20, 2013 at 9:40 AM, Ivan Zhakov wrote: On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben wrote: [...] > The pa

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Mark Phippard
On Thu, Jun 20, 2013 at 9:52 AM, Ivan Zhakov wrote: > On Thu, Jun 20, 2013 at 5:44 PM, Mark Phippard wrote: >> On Thu, Jun 20, 2013 at 9:40 AM, Ivan Zhakov wrote: >>> On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben wrote: >>> [...] >>> The patch to serf 1.2.1 attached to this mail is a (tiny

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Ivan Zhakov
On Thu, Jun 20, 2013 at 5:44 PM, Mark Phippard wrote: > On Thu, Jun 20, 2013 at 9:40 AM, Ivan Zhakov wrote: >> On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben wrote: >> [...] >> >>> The patch to serf 1.2.1 attached to this mail is a (tiny bit cleaned up) >>> hack based on the old code in ra_serf,

RE: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: donderdag 20 juni 2013 15:41 > To: serf-...@googlegroups.com; Bert Huijben > Cc: dev@subversion.apache.org; Gert Kello > Subject: Re: [serf-dev] [Patch] Adding NTLM Support to Serf -

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Mark Phippard
On Thu, Jun 20, 2013 at 9:40 AM, Ivan Zhakov wrote: > On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben wrote: > [...] > >> The patch to serf 1.2.1 attached to this mail is a (tiny bit cleaned up) >> hack based on the old code in ra_serf, some code from an old serf branch and >> the new in serf auth_

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

2013-06-20 Thread Ivan Zhakov
On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben wrote: [...] > The patch to serf 1.2.1 attached to this mail is a (tiny bit cleaned up) > hack based on the old code in ra_serf, some code from an old serf branch and > the new in serf auth_kerb code, which re-enables the NTLM authentication > scheme