Re: 1.10 task: error leaks

2017-12-16 Thread Daniel Shahaf
Julian Foad wrote on Fri, 15 Dec 2017 19:51 +: > r1818320. > > That's the lot. Thanks, Julian!

Re: 1.10 task: error leaks

2017-12-15 Thread Julian Foad
subversion/tests/libsvn_repos/authz-test.c:280:5: print_user_rights(NULL, NULL, 0, &authz->anon_rights, pool); subversion/tests/libsvn_repos/authz-test.c:282:5: print_user_rights(NULL, NULL, 0, &authz->authn_rights, pool); subversion/tests/libsvn_client/conflicts-test.c:543:7:    sbo

Re: 1.10 task: error leaks

2017-12-15 Thread Julian Foad
Daniel Shahaf wrote: The release branch creation checkpoints calls for checking for error leaks, so here's the output of tools/dev/warn-unused-result.sh [...] ...: warning: 'warn_unused_result' attribute only applies to functions, methods, and classes [-Wignored-attributes] This kind of warn

Re: 1.10 task: error leaks

2017-12-11 Thread Daniel Shahaf
Julian Foad wrote on Mon, 11 Dec 2017 19:51 +: > Daniel Shahaf wrote: > > I think we should enable this warning by default in maintainer mode in > > supporting compilers, but that's a separate discussion to just fixing > > these error leaks in trunk (& 1.10.x). > > +1. I was going to say that,

Re: 1.10 task: error leaks

2017-12-11 Thread Julian Foad
Daniel Shahaf wrote: [...] svn_element__tree_set(branch->priv->element_tree, old_eid, NULL); svn_element__tree_set(branch->priv->element_tree, new_eid, element); svn_element__tree_set(branch->priv->element_tree, eid, element); svn_element__tree_set(new_subtree, new_sub

Re: 1.10 task: error leaks

2017-12-11 Thread Julian Foad
Daniel Shahaf wrote: The release branch creation checkpoints calls for checking for error leaks, so here's the output of tools/dev/warn-unused-result.sh (after removing the __attribute__ from svn_error__malfunction()): [about 41 instances] Thank you, Daniel! Anyone volunteering to fix them?

1.10 task: error leaks

2017-12-11 Thread Daniel Shahaf
The release branch creation checkpoints calls for checking for error leaks, so here's the output of tools/dev/warn-unused-result.sh (after removing the __attribute__ from svn_error__malfunction()): [[[ subversion/libsvn_delta/branch.c:485:11: warning: ignoring return value of function declared wi