2012, 20:59
Subject: Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in
/subversion/trunk: ./ subversion/libsvn_delta/compat.c]
Julian Foad wrote on Mon, Apr 23, 2012 at 20:40:59 +0100:
Daniel Shahaf wrote:
Julian Foad wrote:
I (Julian Foad) wrote:
There isn't
Bert Huijben wrote:
you could just use
assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or
SVN_ERR_ASSERT() if you also want to slow down release versions)
The policy is: always use 'SVN_ERR_ASSERT' rather than 'assert' (in functions
that return svn_error_t).
Of
Julian Foad wrote on Mon, Apr 23, 2012 at 17:01:33 +0100:
Bert Huijben wrote:
you could just use
assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or
SVN_ERR_ASSERT() if you also want to slow down release versions)
The policy is: always use 'SVN_ERR_ASSERT'
I (Julian Foad) wrote:
There isn't currently an easy build switch (such as NDEBUG) to disable
SVN_ERR_ASSERT completely at compile time. That's just a side issue. If
you want such a switch, just ask; we can easily create one. Or if you think
we
need two levels of assertions -- one for
On Mon, Apr 23, 2012 at 11:01 AM, Julian Foad
julianf...@btopenworld.com wrote:
Bert Huijben wrote:
you could just use
assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or
SVN_ERR_ASSERT() if you also want to slow down release versions)
The policy is: always use
Julian Foad wrote on Mon, Apr 23, 2012 at 17:18:22 +0100:
I (Julian Foad) wrote:
There isn't currently an easy build switch (such as NDEBUG) to disable
SVN_ERR_ASSERT completely at compile time. That's just a side issue. If
you want such a switch, just ask; we can easily create one.
-Original Message-
From: Julian Foad [mailto:julianf...@btopenworld.com]
Sent: maandag 23 april 2012 18:02
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in
/subversion/trunk: ./ subversion/libsvn_delta/compat.c
Julian Foad wrote on Mon, Apr 23, 2012 at 20:40:59 +0100:
Daniel Shahaf wrote:
Julian Foad wrote:
I (Julian Foad) wrote:
There isn't currently an easy build switch (such as NDEBUG) to disable
SVN_ERR_ASSERT completely at compile time. That's just a side issue.
If
you
- Original Message -
From: Daniel Shahaf danie...@elego.de
To: Julian Foad julianf...@btopenworld.com
Cc: Bert Huijben b...@qqmail.nl; dev@subversion.apache.org
dev@subversion.apache.org
Sent: Monday, 23 April 2012, 20:59
Subject: Re: Always use SVN_ERR_ASSERT [was: svn commit
9 matches
Mail list logo
