Re: svn commit: r1723876 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c

2016-02-05 Thread Evgeny Kotkov
Bert Huijben writes: > The more interesting question is: what is the status of this branch? > > I would like to see this merged to trunk, unless there are some new problems. (Sorry for the delay in response.) I think that the new API makes sense by itself, and could be useful. But we didn't se

RE: svn commit: r1723876 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c

2016-01-27 Thread Bert Huijben
; From: kot...@apache.org [mailto:kot...@apache.org] > Sent: zaterdag 9 januari 2016 19:59 > To: comm...@subversion.apache.org > Subject: svn commit: r1723876 - in /subversion/branches/fs-node- > api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h > libsvn_fs/

Re: FS Node API

2016-01-11 Thread Stefan Fuhrmann
sense because the switch-over to the new API will be very noisy. Otherwise, it could be done on /trunk directly - and be reverted again if necessary. I don't like developing new features in branches, so I consider this branch as experiment to explore the FS node API idea and ma

Re: svn commit: r1723900 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c tests/libsvn_fs/fs-t

2016-01-11 Thread Evgeny Kotkov
Bert Huijben writes: > A quick review showed one minor issue, see inline. [...] >> @@ -2399,6 +2422,17 @@ svn_fs_file_length(svn_filesize_t *lengt >> * @since New in 1.6. >> */ >> svn_error_t * >> +svn_fs_file_checksum2(svn_checksum_t **checksum, >> + svn_checksum_kind

RE: svn commit: r1723900 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c tests/libsvn_fs/fs-t

2016-01-11 Thread Bert Huijben
A quick review showed one minor issue, see inline. > -Original Message- > From: kot...@apache.org [mailto:kot...@apache.org] > Sent: zondag 10 januari 2016 04:21 > To: comm...@subversion.apache.org > Subject: svn commit: r1723900 - in /subversion/branches/fs-node- &

Re: FS Node API

2016-01-09 Thread Ivan Zhakov
rtly in code for the new API. > > -- Stefan^2. > > > Questions / Feedback to fs-node-api as of r1723819 > -- > > [Not commenting on the implementation since that depends > on points in the other sections.] > > * BRANCH-README:

FS Node API

2016-01-08 Thread Stefan Fuhrmann
s. Below there is a list of questions that I had when reviewing the first few commits. There are also sections on what I have in mind and partly in code for the new API. -- Stefan^2. Questions / Feedback to fs-node-api as of r1723819 -- [Not comm