Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-20 Thread C. Michael Pilato
On 04/20/2011 07:40 PM, Stefan Fuhrmann wrote: > Literally main(). Setting up caching limits etc. is similar > to creating the apr root pool and limiting its allocator - > which is done inside main(). > > Also, this is clearly tool-specific as svn.exe seems to be > the only tool that would want to

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-20 Thread Stefan Fuhrmann
On 18.04.2011 21:09, C. Michael Pilato wrote: On 04/16/2011 08:40 AM, Stefan Fuhrmann wrote: On 14.04.2011 22:32, Branko Čibej wrote: On 14.04.2011 21:03, Daniel Shahaf wrote: On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" wrote: I'm honestly not quite sure exactly where the right pl

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-18 Thread C. Michael Pilato
On 04/16/2011 08:40 AM, Stefan Fuhrmann wrote: > On 14.04.2011 22:32, Branko Čibej wrote: >> On 14.04.2011 21:03, Daniel Shahaf wrote: >>> On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" >>> wrote: I'm honestly not quite sure exactly where the right place is. I don't really see wh

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-16 Thread Stefan Fuhrmann
On 14.04.2011 22:32, Branko Čibej wrote: On 14.04.2011 21:03, Daniel Shahaf wrote: On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" wrote: On 04/13/2011 06:52 PM, Stefan Fuhrmann wrote: The code in question has evolved over many months so it is very possible that the name of svn_fs_get_c

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-14 Thread Branko Čibej
On 14.04.2011 21:03, Daniel Shahaf wrote: > On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" > wrote: >> On 04/13/2011 06:52 PM, Stefan Fuhrmann wrote: >>> The code in question has evolved over many months so it is >>> very possible that the name of svn_fs_get_cache_config() >>> and friends i

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-14 Thread Daniel Shahaf
On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" wrote: > On 04/13/2011 06:52 PM, Stefan Fuhrmann wrote: > > The code in question has evolved over many months so it is > > very possible that the name of svn_fs_get_cache_config() > > and friends is no longer appropriate. The same goes for the

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-14 Thread C. Michael Pilato
On 04/13/2011 06:52 PM, Stefan Fuhrmann wrote: > The code in question has evolved over many months so it is > very possible that the name of svn_fs_get_cache_config() > and friends is no longer appropriate. The same goes for the > place that this has been implemented. > > From a design perspective

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-13 Thread Daniel Shahaf
On Thu, 14 Apr 2011 00:52 +0200, "Stefan Fuhrmann" wrote: > On 13.04.2011 03:14, C. Michael Pilato wrote: > > On 04/12/2011 05:11 PM, arfre...@apache.org wrote: > >> Author: arfrever > >> Date: Tue Apr 12 21:11:46 2011 > >> New Revision: 1091573 > >> > >> URL: http://svn.apache.org/viewvc?rev=109

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-13 Thread Stefan Fuhrmann
On 13.04.2011 03:14, C. Michael Pilato wrote: On 04/12/2011 05:11 PM, arfre...@apache.org wrote: Author: arfrever Date: Tue Apr 12 21:11:46 2011 New Revision: 1091573 URL: http://svn.apache.org/viewvc?rev=1091573&view=rev Log: Followup to r1090784: * build.conf (libsvn_ra.libs): Add libsvn_

Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 05:11 PM, arfre...@apache.org wrote: > Author: arfrever > Date: Tue Apr 12 21:11:46 2011 > New Revision: 1091573 > > URL: http://svn.apache.org/viewvc?rev=1091573&view=rev > Log: > Followup to r1090784: > > * build.conf > (libsvn_ra.libs): Add libsvn_fs_util. Whoa. This doesn't