Re: Recurse into same-repos externals at commit time.

2011-08-30 Thread Johan Corveleyn
On Tue, Aug 30, 2011 at 8:55 AM, Markus Schaber wrote: [...] >> Questions remain about passing externals explicitly: >> >> - when an external is passed as explicit target, still require --include- >> externals? > > IMHO: Do not require --include-externals. If I only want to commit a single > fi

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Neels J Hofmeyr
On 08/29/2011 06:15 PM, Neels J Hofmeyr wrote: > - when a *pegged* external is passed as explicit target (and say even if > --include-externals is passed), should we *still* refuse to commit it? > > I'd say [...] yes (thinking of avoiding > inconsistent external state as seen with file externals,

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Neels J Hofmeyr
On 08/29/2011 08:46 PM, C. Michael Pilato wrote: >sne-wc-top (an empty wc) > unversioned > sne-wc-nested (a different empty wc from svn-wc-top) > unversioned >sne-wc-ext (a third, different empty wc, which is an > externa

RE: Recurse into same-repos externals at commit time.

2011-08-29 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: maandag 29 augustus 2011 21:55 > To: Neels J Hofmeyr > Cc: dev@subversion.apache.org > Subject: Re: Recurse into same-repos externals at commit time. > > On 08/29/2011 02:47 P

RE: Recurse into same-repos externals at commit time.

2011-08-29 Thread Bert Huijben
> -Original Message- > From: Neels J Hofmeyr [mailto:ne...@elego.de] > Sent: maandag 29 augustus 2011 20:47 > To: dev@subversion.apache.org > Subject: Re: Recurse into same-repos externals at commit time. > > On 08/29/2011 06:23 PM, C. Michael Pilato wrote: >

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread C. Michael Pilato
On 08/29/2011 02:47 PM, Neels J Hofmeyr wrote: > On 08/29/2011 06:23 PM, C. Michael Pilato wrote: >> On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: >>> - when an external is passed as explicit target, still require >>> --include-externals? >> >> No. Because we've recommended in the issue I referen

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Daniel Shahaf
C. Michael Pilato wrote on Mon, Aug 29, 2011 at 14:46:40 -0400: > On 08/29/2011 02:23 PM, Daniel Shahaf wrote: > > C. Michael Pilato wrote on Mon, Aug 29, 2011 at 12:23:34 -0400: > >> On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: > >>> If user wants to commit to a *pegged* external, user should ju

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Neels J Hofmeyr
On 08/29/2011 06:23 PM, C. Michael Pilato wrote: > On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: >> - when an external is passed as explicit target, still require >> --include-externals? > > No. Because we've recommended in the issue I referenced exactly this > behavior as a workaround for this

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread C. Michael Pilato
On 08/29/2011 02:23 PM, Daniel Shahaf wrote: > C. Michael Pilato wrote on Mon, Aug 29, 2011 at 12:23:34 -0400: >> On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: >>> If user wants to commit to a *pegged* external, user should just use a >>> different, non-externals-ized checkout. >> >> AFAIK, we don

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Daniel Shahaf
C. Michael Pilato wrote on Mon, Aug 29, 2011 at 12:23:34 -0400: > On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: > > If user wants to commit to a *pegged* external, user should just use a > > different, non-externals-ized checkout. > > AFAIK, we don't have the means to detect and prevent this acti

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread C. Michael Pilato
On 08/29/2011 12:15 PM, Neels J Hofmeyr wrote: > On 08/29/2011 05:48 PM, C. Michael Pilato wrote: >> No sweat. 'svn commit --include-externals' sounds like a fine plan. > > +1 and volunteering. > > So by default, *all* externals shall be skipped from commit (dir and file > externals alike). > >

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread Neels J Hofmeyr
On 08/29/2011 05:48 PM, C. Michael Pilato wrote: > No sweat. 'svn commit --include-externals' sounds like a fine plan. +1 and volunteering. So by default, *all* externals shall be skipped from commit (dir and file externals alike). When --include-externals is passed to 'svn commit', *all* exter

Re: Recurse into same-repos externals at commit time.

2011-08-29 Thread C. Michael Pilato
On 08/29/2011 11:45 AM, Bert Huijben wrote: > > >> -Original Message- >> From: C. Michael Pilato [mailto:cmpil...@collab.net] >> Sent: maandag 29 augustus 2011 17:40 >> To: Neels J Hofmeyr >> Cc: Subversion Development >> Subject: Recurse into same-repos externals at commit time. (was: [P

RE: Recurse into same-repos externals at commit time. (was: [PATCH] don't recursively-commit pegged file externals)

2011-08-29 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: maandag 29 augustus 2011 17:40 > To: Neels J Hofmeyr > Cc: Subversion Development > Subject: Recurse into same-repos externals at commit time. (was: [PATCH] > don't recursively-commit pegged file externals