Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-08 Thread Johan Corveleyn
On Sat, Jan 7, 2012 at 10:57 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sat, Jan 7, 2012 at 7:14 PM, Greg Stein gst...@gmail.com wrote: On Jan 7, 2012 8:39 AM, Johan Corveleyn jcor...@gmail.com wrote: ... BTW, I noticed that, before r1209610, my release build was failing for another

RE: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Bert Huijben
: 6-1-2012 23:50 To: Daniel Shahaf Cc: Subversion Development; Hyrum Wright Subject: Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c On Fri, Jan 6, 2012 at 2:45 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Fri, Jan 06, 2012 at 02:12:15 +0100

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Johan Corveleyn
From: Johan Corveleyn Sent: 6-1-2012 23:50 To: Daniel Shahaf Cc: Subversion Development; Hyrum Wright Subject: Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c On Fri, Jan 6, 2012 at 2:45 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Greg Stein
On Jan 7, 2012 8:39 AM, Johan Corveleyn jcor...@gmail.com wrote: ... On Sat, Jan 7, 2012 at 10:30 AM, Bert Huijben b...@qqmail.nl wrote: This patch broke the debug shared library builds on Windows. Release and/or static builds still work. Note that a similar patch was applied and later

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Johan Corveleyn
On Sat, Jan 7, 2012 at 7:14 PM, Greg Stein gst...@gmail.com wrote: On Jan 7, 2012 8:39 AM, Johan Corveleyn jcor...@gmail.com wrote: ... BTW, I noticed that, before r1209610, my release build was failing for another reason: ..\..\..\subversion\libsvn_subr\debug.c(111): error C4013: 'SVN_DBG'

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-06 Thread Johan Corveleyn
On Fri, Jan 6, 2012 at 2:45 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Fri, Jan 06, 2012 at 02:12:15 +0100: On Fri, Dec 2, 2011 at 7:04 PM,  hwri...@apache.org wrote: Author: hwright Date: Fri Dec  2 18:04:14 2011 New Revision: 1209610 URL:

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-06 Thread Daniel Shahaf
Johan Corveleyn wrote on Fri, Jan 06, 2012 at 23:50:02 +0100: On Fri, Jan 6, 2012 at 2:45 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Fri, Jan 06, 2012 at 02:12:15 +0100: On Fri, Dec 2, 2011 at 7:04 PM,  hwri...@apache.org wrote: Author: hwright Date: Fri

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-06 Thread Daniel Shahaf
And a bit of background... build/generator/extractor.py is a file used by gen-make.py on Windows to construct the list of functions that the DLL's export. That file is not aware of C preprocessor macros, so functions that are #define'd away on Windows must be explicitly excepted in it. r1209610

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-06 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Jan 07, 2012 at 01:07:01 +0200: Johan Corveleyn wrote on Fri, Jan 06, 2012 at 23:50:02 +0100: Any ideas on how to fix this? Make extractor.py skip svn_debug.h for debug builds? And if anyone is feeling more ambitious: by making extractor.py pass the files

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-05 Thread Johan Corveleyn
On Fri, Dec 2, 2011 at 7:04 PM, hwri...@apache.org wrote: Author: hwright Date: Fri Dec  2 18:04:14 2011 New Revision: 1209610 URL: http://svn.apache.org/viewvc?rev=1209610view=rev Log: Fix builds where SVN_DEBUG is not defined. * subversion/libsvn_subr/debug.c:  Don't build any of this

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-05 Thread Daniel Shahaf
Does adding those three functions to the exceptions list in build/generator/extractor.py fix the release build (and break the debug build)? Johan Corveleyn wrote on Fri, Jan 06, 2012 at 02:12:15 +0100: On Fri, Dec 2, 2011 at 7:04 PM, hwri...@apache.org wrote: Author: hwright Date: Fri Dec