Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Philip Martin
"Schmidt, Michael" writes: > This patch only fixes the missing notification of starting to export > externals. It does not address the second part of issue #4527, which > is the premature reset of the in_external flag in the case of nested > externals, which also affects checkouts. To me it seems

Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Julian Foad
Philip Martin wrote: > Schmidt, Michael writes: >> This patch only fixes the missing notification of starting to export >> externals. It does not address the second part of issue #4527, which >> is the premature reset of the in_external flag in the case of nested >> externals, which also affects ch

Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Philip Martin
Julian Foad writes: > Other than the indentation, Michael's patch looks like the right fix > in the right place, wouldn't you agree? Yes, I think it is correct. Extending the patch to fix the in_external nesting problem would be ideal but we could commit this version. > Michael, have you teste