Wunused-but-set-parameter warning in svn_wc_get_diff_editor6

2014-08-22 Thread Philip Martin
I see this: ../src/subversion/libsvn_wc/deprecated.c: In function 'svn_wc_get_diff_editor6': ../src/subversion/libsvn_wc/deprecated.c:1991:39: warning: parameter 'ignore_ancestry' set but not used [-Wunused-but-set-parameter] It was added in 1569697. Is this bit redundant or is something missin

Re: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6

2014-08-22 Thread Julian Foad
Philip Martin wrote: > ../src/subversion/libsvn_wc/deprecated.c: In function > 'svn_wc_get_diff_editor6': > ../src/subversion/libsvn_wc/deprecated.c:1991:39: warning: parameter > 'ignore_ancestry' set but not used [-Wunused-but-set-parameter] > > It was added in 1569697.  Is this bit redundant o

RE: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6

2014-08-22 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: vrijdag 22 augustus 2014 12:52 > To: Philip Martin > Cc: dev@subversion.apache.org; Bert Huijben > Subject: Re: Wunused-but-set-parameter warning in > svn_wc_get_diff_editor6 >

Re: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6

2014-08-22 Thread Philip Martin
"Bert Huijben" writes: >> Philip Martin wrote: >> > ../src/subversion/libsvn_wc/deprecated.c: In function >> > 'svn_wc_get_diff_editor6': >> > ../src/subversion/libsvn_wc/deprecated.c:1991:39: warning: parameter >> > 'ignore_ancestry' set but not used [-Wunused-but-set-parameter] >> > >> > It was

Re: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6

2014-08-22 Thread Julian Foad
>>> The 'ignore_ancestry' flag should probably be passed to >>> svn_wc__get_diff_editor(..., ignore-ancestry=ignore_ancestry, ...) instead >>> of passing (..., ignore_ancestry=use_git_diff_format, ...). But then where >>> should 'use_git_diff_format' be used? Bert wrote: >> The git_diff flag, trig