Re: serf error handling for locks without authn

2013-06-05 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: I'm trying to work out what this code should look like. This function is called after LOCK and PROPFIND, but not UNLOCK which has its own code. I think the function should be something like: apr_status_t errcode; if (err) return

Re: serf error handling for locks without authn

2013-06-03 Thread Greg Stein
On Mon, Jun 3, 2013 at 5:14 PM, Philip Martin philip.mar...@wandisco.com wrote: http://subversion.tigris.org/issues/show_bug.cgi?id=4368 Locking with anonymous http fails because there is no username. At That should be allowed. A WebDAV lock does not require an owner. present mod_dav_svn

Re: serf error handling for locks without authn

2013-06-03 Thread Greg Stein
On Mon, Jun 3, 2013 at 6:09 PM, Philip Martin philip.mar...@wandisco.com wrote: Greg Stein gst...@gmail.com writes: On Mon, Jun 3, 2013 at 5:14 PM, Philip Martin philip.mar...@wandisco.com wrote: http://subversion.tigris.org/issues/show_bug.cgi?id=4368 Locking with anonymous http fails

Re: serf error handling for locks without authn

2013-06-03 Thread Ben Reser
On Mon, Jun 3, 2013 at 3:31 PM, Greg Stein gst...@gmail.com wrote: On Mon, Jun 3, 2013 at 6:09 PM, Philip Martin philip.mar...@wandisco.com wrote: Greg Stein gst...@gmail.com writes: On Mon, Jun 3, 2013 at 5:14 PM, Philip Martin philip.mar...@wandisco.com wrote:

Re: serf error handling for locks without authn

2013-06-03 Thread Greg Stein
On Mon, Jun 3, 2013 at 6:48 PM, Ben Reser b...@reser.org wrote: On Mon, Jun 3, 2013 at 3:31 PM, Greg Stein gst...@gmail.com wrote: ... Yeah. HTTP_CONFLICT should be correct, there. Well technically 401 is right but we have now way of filling in the proper WWW-Authenticate header.

Re: serf error handling for locks without authn

2013-06-03 Thread Philip Martin
Ben Reser b...@reser.org writes: That's my fault, I fixed the anonymous locking segfault and chose a 401 to return but I forgot about the WWW-Authenticate header requirement. Not really your fault, even before your r1455352 mod_dav_svn returned 401. Without r1455352 append_locks calls

Re: serf error handling for locks without authn

2013-06-03 Thread Greg Stein
On Mon, Jun 3, 2013 at 7:10 PM, Greg Stein gst...@gmail.com wrote: On Mon, Jun 3, 2013 at 6:48 PM, Ben Reser b...@reser.org wrote: ... I'd argue that we should return a 500 range error since the problem here is that the server is not properly configured. There is really Nah. 500 means there