Re: svn commit: r1197961 - in /subversion/trunk/subversion/libsvn_client: client.h copy.c diff.c info.c merge.c ra.c

2011-11-07 Thread Julian Foad
Greg Stein wrote: > Woah. This is even crazier than what you fixed. *nobody* asks > for the end revision. In fact, the code would have crashed since > END_REVISION was always NULL. No, it wasn't that broken, it was only a bit of an ugly API. Both the END_URL and END_REVISION output pointers were

Re: svn commit: r1197961 - in /subversion/trunk/subversion/libsvn_client: client.h copy.c diff.c info.c merge.c ra.c

2011-11-05 Thread Greg Stein
Woah. This is even crazier than what you fixed. *nobody* asks for the end revision. In fact, the code would have crashed since END_REVISION was always NULL. Thus, ->kind must have never been unspecified. But no matter, as the param is useless. Also note that only one callsite asks for the start, an