Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-03 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, Feb 03, 2012 at 02:07:59 +0100: > On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote: > > It doesn't look like it's multithreaded safe to set, but should it be? > > I am not sure. > > Note that this isn't changing the environment of the currently running > p

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 05:07 PM, Stefan Sperling wrote: On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote: It doesn't look like it's multithreaded safe to set, but should it be? I am not sure. Note that this isn't changing the environment of the currently running process. It takes effect in

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Stefan Sperling
On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote: > It doesn't look like it's multithreaded safe to set, but should it be? I am not sure. Note that this isn't changing the environment of the currently running process. It takes effect in the child process that runs a hook. The intended

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 04:03 PM, Daniel Shahaf wrote: Blair Zajac wrote on Thu, Feb 02, 2012 at 15:41:48 -0800: On 02/02/2012 03:29 PM, s...@apache.org wrote: +/** Set the environment that @ repos's hooks will inherit. + * If this function is not called, hooks will run in an empty environment. + * @sinc

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Daniel Shahaf
Blair Zajac wrote on Thu, Feb 02, 2012 at 15:41:48 -0800: > On 02/02/2012 03:29 PM, s...@apache.org wrote: > >+/** Set the environment that @ repos's hooks will inherit. > >+ * If this function is not called, hooks will run in an empty environment. > >+ * @since New in 1.8. */ > > Is NULL OK? How

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 03:29 PM, s...@apache.org wrote: Author: stsp Date: Thu Feb 2 23:29:11 2012 New Revision: 1239926 URL: http://svn.apache.org/viewvc?rev=1239926&view=rev Log: Add a public libsvn_repos API to set the environment of hook scripts. Modified: subversion/trunk/subversion/include/s