Re: svn commit: r1344825 - in /subversion/trunk/tools/dev/mergegraph: mergegraph.py save_as_sh.py

2012-05-31 Thread Greg Stein
On May 31, 2012 1:30 PM, wrote: >... > +++ subversion/trunk/tools/dev/mergegraph/save_as_sh.py Thu May 31 17:30:17 2012 >... > +def command(out, cmd, *args): > + """Write the shell command CMD with the arguments ARGS to the file-like > + object OUT.""" Please review my earlier comments about

Re: svn commit: r1344825 - in /subversion/trunk/tools/dev/mergegraph: mergegraph.py save_as_sh.py

2012-05-31 Thread Julian Foad
Greg Stein wrote: >On May 31, 2012 1:30 PM, wrote: >>... >> +++ subversion/trunk/tools/dev/mergegraph/save_as_sh.py Thu May 31 17:30:17 >> 2012 >>... >> +def command(out, cmd, *args): >> +  """Write the shell command CMD with the arguments ARGS to the file-like >> +     object OUT.""" >Please re

Re: svn commit: r1344825 - in /subversion/trunk/tools/dev/mergegraph: mergegraph.py save_as_sh.py

2012-05-31 Thread Julian Foad
I (Julian Foad) wrote: > Greg Stein wrote: >>> +def command(out, cmd, *args): >>> +  """Write the shell command CMD with the arguments ARGS to the file-like >>> +     object OUT.""" >> Please review my earlier comments about standard docstring formatting in >> Python. More specifically, PEP 8.

Re: svn commit: r1344825 - in /subversion/trunk/tools/dev/mergegraph: mergegraph.py save_as_sh.py

2012-05-31 Thread Greg Stein
On May 31, 2012 4:45 PM, "Julian Foad" wrote: > > I (Julian Foad) wrote: > > > Greg Stein wrote: > >>> +def command(out, cmd, *args): > >>> + """Write the shell command CMD with the arguments ARGS to the file-like > >>> + object OUT.""" > >> Please review my earlier comments about standard