Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-11 Thread Stefan Fuhrmann
On Mon, Sep 10, 2012 at 12:58 AM, Johan Corveleyn wrote: > On Thu, Sep 6, 2012 at 11:30 PM, wrote: > > Author: stefan2 > > Date: Thu Sep 6 21:30:40 2012 > > New Revision: 1381766 > > > + > > + /* The remaining odd bytes will be examined the naive way: */ > > + for (; ; ++data) > > +if

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-09 Thread Johan Corveleyn
On Thu, Sep 6, 2012 at 11:30 PM, wrote: > Author: stefan2 > Date: Thu Sep 6 21:30:40 2012 > New Revision: 1381766 > > URL: http://svn.apache.org/viewvc?rev=1381766&view=rev > Log: > Many strings we need to convert to UTF-8 (paths, even log messages) > contain large ASCII chars only sections. Ad

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-07 Thread Stefan Fuhrmann
On Fri, Sep 7, 2012 at 7:19 PM, Peter Samuelson wrote: > > [stef...@apache.org] > > + for (; len > 0; ++data, --len) > > + if (*data < 0) > > +return data; > > Two major problems: > > 1) It doesn't account for character sets like Shift-JIS, where state >change is sig

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-07 Thread Stefan Fuhrmann
On Fri, Sep 7, 2012 at 6:18 PM, Branko Čibej wrote: > On 06.09.2012 23:30, stef...@apache.org wrote: > > Author: stefan2 > > Date: Thu Sep 6 21:30:40 2012 > > New Revision: 1381766 > > > > URL: http://svn.apache.org/viewvc?rev=1381766&view=rev > > Log: > > Many strings we need to convert to UTF-

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-07 Thread Peter Samuelson
[stef...@apache.org] > + for (; len > 0; ++data, --len) > + if (*data < 0) > +return data; Two major problems: 1) It doesn't account for character sets like Shift-JIS, where state change is signalled by ASCII 14 and 15 ("shift out", "shift in") 2) It assumes a 'char

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-07 Thread Branko Čibej
On 06.09.2012 23:30, stef...@apache.org wrote: > Author: stefan2 > Date: Thu Sep 6 21:30:40 2012 > New Revision: 1381766 > > URL: http://svn.apache.org/viewvc?rev=1381766&view=rev > Log: > Many strings we need to convert to UTF-8 (paths, even log messages) > contain large ASCII chars only sections