RE: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Bert Huijben
> -Original Message- > From: Mark Phippard [mailto:markp...@gmail.com] > Sent: maandag 29 april 2013 17:59 > To: Philip Martin > Cc: Subversion Development > Subject: Re: svn commit: r1476359 - in > /subversion/trunk/subversion/bindings/javahl/src/org: > apache

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Mark Phippard
On Mon, Apr 29, 2013 at 11:39 AM, Philip Martin wrote: > Mark Phippard writes: > >> I think Synchronized is a better solution, but will not object if you >> want to make the change. > > I'm a novice as far as Java is concerned, I don't know which style is > preferred. This is a decent resource t

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Philip Martin
Mark Phippard writes: > I think Synchronized is a better solution, but will not object if you > want to make the change. I'm a novice as far as Java is concerned, I don't know which style is preferred. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/dow

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Mark Phippard
On Mon, Apr 29, 2013 at 10:44 AM, Philip Martin wrote: >> This would essentially require creating a new object each time the >> method is needed and that would be a lot. My understanding is that >> using synchronize is cheaper in this case. > > The org.apache bindings only use LogDate in CommitI

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Philip Martin
Mark Phippard writes: > On Mon, Apr 29, 2013 at 7:47 AM, Philip Martin > wrote: >> markp...@apache.org writes: >> >>> Author: markphip >>> Date: Fri Apr 26 19:48:34 2013 >>> New Revision: 1476359 >>> >>> URL: http://svn.apache.org/r1476359 >>> Log: >>> JavaHL: fix a thread safety bug that has be

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Mark Phippard
On Mon, Apr 29, 2013 at 7:47 AM, Philip Martin wrote: > markp...@apache.org writes: > >> Author: markphip >> Date: Fri Apr 26 19:48:34 2013 >> New Revision: 1476359 >> >> URL: http://svn.apache.org/r1476359 >> Log: >> JavaHL: fix a thread safety bug that has been observed in Subclipse. >> >> The J

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

2013-04-29 Thread Philip Martin
markp...@apache.org writes: > Author: markphip > Date: Fri Apr 26 19:48:34 2013 > New Revision: 1476359 > > URL: http://svn.apache.org/r1476359 > Log: > JavaHL: fix a thread safety bug that has been observed in Subclipse. > > The Java SimpleDateFormat class is not thread safe. Solved by > synchron