Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-07 Thread Ivan Zhakov
On 2 August 2014 18:45, Branko Čibej br...@wandisco.com wrote: On 02.08.2014 15:20, Alan Barrett wrote: On Tue, 29 Jul 2014, C. Michael Pilato wrote: This leaves open the possibility of a future additional match mode for regular expressions (using the '^:' magic prefix) should we seek to go

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-07 Thread Branko Čibej
On 07.08.2014 10:30, Ivan Zhakov wrote: On 2 August 2014 18:45, Branko Čibej br...@wandisco.com wrote: On 02.08.2014 15:20, Alan Barrett wrote: On Tue, 29 Jul 2014, C. Michael Pilato wrote: This leaves open the possibility of a future additional match mode for regular expressions (using the

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-06 Thread Stefan Fuhrmann
On Sat, Aug 2, 2014 at 4:45 PM, Branko Čibej br...@wandisco.com wrote: On 02.08.2014 15:20, Alan Barrett wrote: On Tue, 29 Jul 2014, C. Michael Pilato wrote: This leaves open the possibility of a future additional match mode for regular expressions (using the '^:' magic prefix) should we

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-02 Thread Alan Barrett
On Tue, 29 Jul 2014, C. Michael Pilato wrote: This leaves open the possibility of a future additional match mode for regular expressions (using the '^:' magic prefix) should we seek to go there. # Match the trunk and branches subdirs and their children. [repos:^:^/(trunk|branches)(/.*|$)$]

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-02 Thread Branko Čibej
On 02.08.2014 15:20, Alan Barrett wrote: On Tue, 29 Jul 2014, C. Michael Pilato wrote: This leaves open the possibility of a future additional match mode for regular expressions (using the '^:' magic prefix) should we seek to go there. # Match the trunk and branches subdirs and their

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-08-01 Thread Stefan Fuhrmann
On Tue, Jul 29, 2014 at 5:55 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 15:55, Stefan Fuhrmann wrote: [...] So, while you can without doubt parse the file streamily, you cannot begin to build a data model with authz semantics from it streamily. We can go down the path

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Julian Foad
Branko Čibej wrote: Author: stefan2 Without support for wildcards or other patterns, the config struct will only contain a single section for each path.  With wildcards, there may be more than one.  All three of the follwing path rules are equally applicable:    [/foo/*.doc]    * = r   

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 09:49, Julian Foad wrote: Branko Čibej wrote: Author: stefan2 Without support for wildcards or other patterns, the config struct will only contain a single section for each path. With wildcards, there may be more than one. All three of the follwing path rules are equally

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Julian Foad
Brane wrote: Julian Foad wrote: such as:   /projects/*/include/*_private.h and   /projects/*/include/foo.h I'll just note that these two patterns cannot possibly be confused, since *_private.h and foo.h will never match the same file name. Oops, I meant 'foo_private.h' for the latter. -

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 12:06, Julian Foad wrote: Brane wrote: Julian Foad wrote: such as: /projects/*/include/*_private.h and /projects/*/include/foo.h I'll just note that these two patterns cannot possibly be confused, since *_private.h and foo.h will never match the same file name. Oops, I

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Julian Foad
Brane wrote: if the patterns were:     [*/projects/f*/include/*.h]     [*/projects/*o/include/*.h] (Ugh, I don't like the prefix '*' which I think you're using to mean 'wildcards enabled'.) where both f* and *o match foo, we should always pick whichever pattern was defined first in the

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 12:25, Julian Foad wrote: Brane wrote: if the patterns were: [*/projects/f*/include/*.h] [*/projects/*o/include/*.h] (Ugh, I don't like the prefix '*' which I think you're using to mean 'wildcards enabled'.) I don't care what prefix we use, but I do care that the

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 12:46, Branko Čibej wrote: If we decide that the config parser is fair game (since I'm already changing it to optimize the construction of the in-memory authz representation), we could, for example, pick {/fspath-pattern} {repos:/fspath-pattern} ... although note that

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Johan Corveleyn
On Tue, Jul 29, 2014 at 12:46 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 12:25, Julian Foad wrote: Brane wrote: if the patterns were: [*/projects/f*/include/*.h] [*/projects/*o/include/*.h] (Ugh, I don't like the prefix '*' which I think you're using to mean

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 12:55, Johan Corveleyn wrote: On Tue, Jul 29, 2014 at 12:46 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 12:25, Julian Foad wrote: Brane wrote: if the patterns were: [*/projects/f*/include/*.h] [*/projects/*o/include/*.h] (Ugh, I don't like the prefix

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Stefan Fuhrmann
On Mon, Jul 28, 2014 at 7:38 PM, Branko Čibej br...@wandisco.com wrote: On 28.07.2014 19:19, stef...@apache.org wrote: Author: stefan2 Date: Mon Jul 28 17:19:47 2014 New Revision: 1614080 URL: http://svn.apache.org/r1614080 Log: On the authzperf branch: Implement the notion of path rule

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Stefan Fuhrmann
On Tue, Jul 29, 2014 at 12:55 PM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Jul 29, 2014 at 12:46 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 12:25, Julian Foad wrote: Brane wrote: if the patterns were: [*/projects/f*/include/*.h] [*/projects/*o/include/*.h]

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 13:34, Stefan Fuhrmann wrote: On Mon, Jul 28, 2014 at 7:38 PM, Branko Čibej br...@wandisco.com wrote: On 28.07.2014 19:19, stef...@apache.org wrote: Author: stefan2 Date: Mon Jul 28 17:19:47 2014 New Revision: 1614080 URL: http://svn.apache.org/r1614080 Log: On the authzperf

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Stefan Fuhrmann
On Tue, Jul 29, 2014 at 1:52 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 13:34, Stefan Fuhrmann wrote: On Mon, Jul 28, 2014 at 7:38 PM, Branko Čibej br...@wandisco.com br...@wandisco.com wrote: On 28.07.2014 19:19, stef...@apache.org wrote: Author: stefan2 Date: Mon Jul

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 14:55, Stefan Fuhrmann wrote: On Tue, Jul 29, 2014 at 1:52 PM, Branko Čibej br...@wandisco.com mailto:br...@wandisco.com wrote: On 29.07.2014 13:34, Stefan Fuhrmann wrote: On Mon, Jul 28, 2014 at 7:38 PM, Branko Čibej br...@wandisco.com mailto:br...@wandisco.com wrote:

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread C. Michael Pilato
On 07/29/2014 06:46 AM, Branko Čibej wrote: If we want to support wildcards, we /have/ to invent a different syntax for wildcard rules. My working proposal is to add a literal '*' before the leading slash in the path: [*/fspath-pattern] [repos:*/fspath-pattern] because neither

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Philip Martin
Branko Čibej br...@wandisco.com writes: Let's please have the rules documented in the wiki, then we can comment on them. * Select the path rule(s) that cover the largest section of the path. This is what we do today and there can be only one such match w/o the use of wildcards. * If

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Stefan Fuhrmann
On Tue, Jul 29, 2014 at 3:28 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 14:55, Stefan Fuhrmann wrote: On Tue, Jul 29, 2014 at 1:52 PM, Branko Čibej br...@wandisco.com wrote: On 29.07.2014 13:34, Stefan Fuhrmann wrote: On Mon, Jul 28, 2014 at 7:38 PM, Branko Čibej

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-29 Thread Branko Čibej
On 29.07.2014 15:55, Stefan Fuhrmann wrote: On Tue, Jul 29, 2014 at 3:28 PM, Branko Čibej br...@wandisco.com mailto:br...@wandisco.com wrote: On 29.07.2014 14:55, Stefan Fuhrmann wrote: On Tue, Jul 29, 2014 at 1:52 PM, Branko Čibej br...@wandisco.com mailto:br...@wandisco.com

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

2014-07-28 Thread Branko Čibej
On 28.07.2014 19:19, stef...@apache.org wrote: Author: stefan2 Date: Mon Jul 28 17:19:47 2014 New Revision: 1614080 URL: http://svn.apache.org/r1614080 Log: On the authzperf branch: Implement the notion of path rule ordering by making svn_config_t iterate through sections in declaration