Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

2016-05-19 Thread Stefan Fuhrmann
On 13.05.2016 19:51, Evgeny Kotkov wrote: Stefan Fuhrmann writes: The new condition looks fairly suspicious. Sure, but no worse than before. I think it's actually worse than before, as now it looks like this function was updated for Python 3, whereas in fact it gets all

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

2016-05-13 Thread Evgeny Kotkov
Stefan Fuhrmann writes: >> The new condition looks fairly suspicious. > > Sure, but no worse than before. I think it's actually worse than before, as now it looks like this function was updated for Python 3, whereas in fact it gets all the special cases like "value[0] ==

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

2016-05-12 Thread Stefan Fuhrmann
On 12.05.2016 23:49, Evgeny Kotkov wrote: Stefan Fuhrmann writes: * subversion/tests/cmdline/svntest/actions.py (set_prop): If we write a bytes string to a prop, treat it as binary that can't be passed directly via command line argument. [...] - if

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

2016-05-12 Thread Evgeny Kotkov
Stefan Fuhrmann writes: > * subversion/tests/cmdline/svntest/actions.py > (set_prop): If we write a bytes string to a prop, treat it as binary > that can't be passed directly via command line argument. [...] > - if value and (value[0] == '-' or '\x00' in