Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Julian Foad
On Tue, 2010-05-04, hwri...@apache.org wrote: > Author: hwright > Date: Tue May 4 09:45:43 2010 > New Revision: 940786 > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > Log: > Add a callback to the public patch API, to allow consumers to collect > information about the patch targets. T

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > Author: hwright > Date: Tue May 4 09:45:43 2010 > New Revision: 940786 > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > Log: > Add a callback to the public patch API, to allow consumers to collect > information about

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 11:36:49AM +0100, Julian Foad wrote: > Wasn't the idea that the caller could choose whether the patched result > should be written straight to the target file or to somewhere else? No, that wasn't the idea. The patched result is *always* written to tempfiles first. Always

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Hyrum K. Wright
On Tue, May 4, 2010 at 12:45 PM, Stefan Sperling wrote: > On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > > Author: hwright > > Date: Tue May 4 09:45:43 2010 > > New Revision: 940786 > > > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > > Log: > > Add a callback t

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Julian Foad
On Tue, 2010-05-04 at 17:55 +0200, Hyrum K. Wright wrote: > On Tue, May 4, 2010 at 12:45 PM, Stefan Sperling wrote: > > > On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > > > Author: hwright > > > Date: Tue May 4 09:45:43 2010 > > > New Revision: 940786 > > > > > > URL: http

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Hyrum K. Wright
On Tue, May 4, 2010 at 12:36 PM, Julian Foad wrote: > On Tue, 2010-05-04, hwri...@apache.org wrote: > > Author: hwright > > Date: Tue May 4 09:45:43 2010 > > New Revision: 940786 > > > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > > Log: > > Add a callback to the public patch API, to

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-05 Thread Julian Foad
On Tue, 2010-05-04 at 23:23 +0200, Hyrum K. Wright wrote: > On Tue, May 4, 2010 at 12:36 PM, Julian Foad wrote: > > Jumping in at this point, I can't grok this doc string. Can you write > > it as a statement of what this function (a function of this type) is > > required to do or promises to do or