Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-16 Thread Julian Foad
On Wed, 2010-09-15 at 20:59 +0200, Stefan Sperling wrote: > On Wed, Sep 15, 2010 at 05:12:43PM +0100, Julian Foad wrote: > > > > > + * @since New in 1.7. > > > > > + */ > > > > > +svn_error_t * > > > > > +svn_cstring_strtoi64(apr_int64_t *n, const char *str, > > > > > + apr_int6

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 05:12:43PM +0100, Julian Foad wrote: > > > > + * @since New in 1.7. > > > > + */ > > > > +svn_error_t * > > > > +svn_cstring_strtoi64(apr_int64_t *n, const char *str, > > > > + apr_int64_t minval, apr_int64_t maxval, > > > > + int base

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
Stefan Sperling wrote: > On Wed, Sep 15, 2010 at 02:14:36PM +0100, Julian Foad wrote: > > On Tue, 2010-09-07, s...@apache.org wrote: > > > * subversion/include/svn_string.h > > > (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi, > > >svn_cstring_strtoui64, svn_cstring_atoui64, svn_

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Philip Martin
Stefan Sperling writes: > The translation issues is why I didn't use the APR_[U]INT64_T_FMT. > It's either using it and make life hard for translators, or have these > warnings... neither solution is perfect. Or is there a better solution? Have two format strings and pick the right one based on

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 02:27:21PM +0100, Julian Foad wrote: > Also printf formatting type mismatches: > > subversion/libsvn_subr/svn_string.c: In function > 'svn_cstring_strtoui64': > subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long > unsigned int', but argument 5 has type

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 02:14:36PM +0100, Julian Foad wrote: > On Tue, 2010-09-07, s...@apache.org wrote: > > Author: stsp > > Date: Tue Sep 7 00:09:46 2010 > > New Revision: 993183 > > > > URL: http://svn.apache.org/viewvc?rev=993183&view=rev > > Log: > > Introduce a new family of functions to p

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
Also printf formatting type mismatches: subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoui64': subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long unsigned int', but argument 5 has type 'apr_uint64_t' subversion/libsvn_subr/svn_string.c:662: format '%lu' exp

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
On Tue, 2010-09-07, s...@apache.org wrote: > Author: stsp > Date: Tue Sep 7 00:09:46 2010 > New Revision: 993183 > > URL: http://svn.apache.org/viewvc?rev=993183&view=rev > Log: > Introduce a new family of functions to parse numbers from strings. Looks useful. Thanks. > The goal is to replace d

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-07 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 09:17:10AM +0200, Stephen Butler wrote: > >> * subversion/include/svn_string.h > >> (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi, > >> svn_cstring_strtoui64, svn_cstring_atoui64, svn_cstring_atoui): Declare. > > Uh oh, some buildbots complain about APR_UIN

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-07 Thread Stephen Butler
Hi Stefan, APR is a moving target... On Sep 7, 2010, at 6:42 , Greg Stein wrote: > The buildbots are failing all over the place after this revision... > > On Mon, Sep 6, 2010 at 20:09, wrote: >> Author: stsp >> Date: Tue Sep 7 00:09:46 2010 >> New Revision: 993183 >> >> URL: http://svn.apac

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-06 Thread Greg Stein
The buildbots are failing all over the place after this revision... On Mon, Sep 6, 2010 at 20:09, wrote: > Author: stsp > Date: Tue Sep  7 00:09:46 2010 > New Revision: 993183 > > URL: http://svn.apache.org/viewvc?rev=993183&view=rev > Log: > Introduce a new family of functions to parse numbers

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-06 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 12:09:47AM -, s...@apache.org wrote: > Author: stsp > Date: Tue Sep 7 00:09:46 2010 > New Revision: 993183 > > URL: http://svn.apache.org/viewvc?rev=993183&view=rev > Log: > Introduce a new family of functions to parse numbers from strings. > * subversion/mod_dav_svn/