Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-09-13 Thread Roberto E. Vargas Caballero
> I'm fairly certain that we are supposed to always add 32 unless in SGR > mode. I've just now confirmed with the xterm (version 296) source code: Ok, patch applied. Thanks!. -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

[dev] [tabbed] [PATCH] Fix a bug with mouse-selecting (particularly nasty when closing tabs).

2013-09-13 Thread Alexander Sedov
If not all tabs are shown, trying to select a tab with a mouse checked against coordinates of tabs when they were last drawn. This lead to incorrectly choosing tabs not even on screen. Checking only drawn ones should help. You can reproduce the bug by running old version of tabbed, opening 8 tabs,

Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-09-13 Thread Michael Forney
On Thu, 01 Aug 2013 10:10:23 +0200, "Roberto E. Vargas Caballero" wrote: > > This suggests that we should still add 32 to the button value when in > > MODE_MOUSEX10. > > It is no clear for me if we have to add it or not, did you test it with > other emulators? Hi, I apologize for the delay