Quoth Roberto E. Vargas Caballero:
It looks like you can use SOUP_CHECK_VERSION(2, 34, 0) to test for the
version that supports disk cache. May you please try your patch with that
code, and send me an updated patch? I will then test on my own system with
support, and verify that the
Quoth Nick:
Quoth Roberto E. Vargas Caballero:
I compiled it in jessie with this patch:
It compiles fine with that patch on Wheezy, too.
Not even all of Roberto's patch seems necessary. The attached patch
works for me.
diff --git a/surf.c b/surf.c
index 87c10ef..0c2d580 100644
---
On Tue, Apr 14, 2015 at 12:55 PM, Gregor Best g...@ring0.de wrote:
The cause seems to be that for bot `term.line` and `term.alt` are NULL
at this point. While this does mean that even with a `len` parameter of
0, the `dst` pointer gets touched, I don't think it's ever right to call
either
Not always is desirable to create a pseudo terminal, and some times
we want to open a terminal emulator over a tty line. With this new
patch is possible to do someting like:
$ st -l /dev/ttyS0 115200
Without this option was needed to launch another terminal emulator
over st (for example
It compiles fine with that patch on Wheezy, too.
Not even all of Roberto's patch seems necessary. The attached patch
works for me.
Maybe we should add these lines to the base version, at least
until the cache code becomes more stable.
Regards,
On those platforms that need that define set before the include, does the -D
argument actually work?
Ben
Original Message
From: Nick
Sent: Tuesday, April 14, 2015 2:21 AM
To: dev mail list
Reply To: dev mail list
Subject: Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk
On 14 April 2015 at 13:50, Dimitris Papastamos s...@2f30.org wrote:
dst and src are required to be valid objects even if n is 0, otherwise
this is undefined behaviour.
I looked this up in C11. Seems to be the case:
7.24.2.1.2. The memcpy function copies n characters from the object
pointed
Well, that sucks. Thank you for bringing that to my attention.
I think an attachment is better in this case...
On Tue, Apr 14, 2015 at 5:29 PM, Eric Pruitt eric.pru...@gmail.com wrote:
On Tue, Apr 14, 2015 at 05:25:15PM +0200, Willem van de Krol wrote:
- Text *data = text_load(filename
Permission errors are handled in text_load(). To detect these errors,
and other open() errors (opening a directory, for example), check the
return value of text_load().
This fixes a segmentation fault when opening a directory.
Also, opening a file you are not permitted to read, will now give an
On Tue, Apr 14, 2015 at 04:33:56PM +0100, Connor Lane Smith wrote:
On 14 April 2015 at 13:50, Dimitris Papastamos s...@2f30.org wrote:
dst and src are required to be valid objects even if n is 0, otherwise
this is undefined behaviour.
I looked this up in C11. Seems to be the case:
On Tue, Apr 14, 2015 at 05:25:15PM +0200, Willem van de Krol wrote:
- Text *data = text_load(filename access(filename, F_OK) == 0 ?
filename : NULL);
Your MUA munged the patch by wrapping a line.
Eric
Quoth tauto...@gmail.com:
On those platforms that need that define set before the include, does the -D
argument actually work?
Yep, the cache seems to work fine.
Cool. My concern is about adding unstable code on a stable distribution.
The disk cache is disabled by default, so it is probably not an issue. If
someone enables it, it is their decision.
I am not the maintainer, so it isn't my call, but if the maintainer wants my
input as the original
On Tue, Apr 14, 2015 at 01:43:56PM +0200, Silvan Jegen wrote:
On Tue, Apr 14, 2015 at 12:55 PM, Gregor Best g...@ring0.de wrote:
The cause seems to be that for bot `term.line` and `term.alt` are NULL
at this point. While this does mean that even with a `len` parameter of
0, the `dst`
14 matches
Mail list logo
