Re: [dev] st: Large pile of code

2013-04-25 Thread Kent Overstreet
On Wed, Apr 24, 2013 at 11:59 PM, Alexander Sedov wrote: > 2013/4/25 Kent Overstreet : >> So, to restate - code should be harder to understand to keep people >> from contributing? > Code should look compact to keep people from adding bloat. Multiple > files by them

Re: [dev] st: Large pile of code

2013-04-24 Thread Kent Overstreet
On Wed, Apr 24, 2013 at 11:48 PM, Alexander Sedov wrote: > Personally, I suspect that this is not going to be positive change in > long run. Dividing into multiple files lowers tolerance threshold for > adding new code. If before that somebody would not add 500 sloc, no > matter what, now he can c

Re: [dev] st: Large pile of code

2013-04-24 Thread Kent Overstreet
On Wed, Apr 24, 2013 at 2:14 PM, wrote: > On Wed, Apr 24, 2013, at 15:32, Kent Overstreet wrote: >> I switched to gnu99 for typeof() - it makes it possible to write min >> and max macros that don't evaluate their arguments twice, and IMO is a >> very worthwhile extensi

Re: [dev] st: Large pile of code

2013-04-24 Thread Kent Overstreet
On Wed, Apr 24, 2013 at 7:23 AM, wrote: > On Wed, Apr 24, 2013, at 9:32, Carlos Torres wrote: >> I like the seperation of term.c from st.c, I agree that makes reading >> st.c clearer. I can't comment on the removal of forward declarations, >> typedefs and static vars though the resulting differ

[dev] st: Large pile of code

2013-04-23 Thread Kent Overstreet
First off - nice work! Awhile back I started hacking on st in my spare time. I haven't added anything earth shaking - the majority of what I've been doing has been refactoring and rewriting bits to make the code better. Anyways, the way I've been doing things has diverged enough that I don't know