Re: [dev][PATCH][quark] Clean up the log-facility [fixed-PATCH]

2014-03-03 Thread FRIGN
On Mon, 3 Mar 2014 23:28:13 + sin wrote: > I don't agree. At the very least have a look at eprintf() from the > 'The practice of programming'. We are using similar functions in sbase > and ubase. In sbase and ubase, this definitely makes sense. However, what we're dealing with here is a di

Re: [dev][PATCH][quark] Clean up the log-facility [fixed-PATCH]

2014-03-03 Thread sin
On Mon, Mar 03, 2014 at 09:53:20PM +0100, FRIGN wrote: > On Mon, 3 Mar 2014 21:16:46 + > sin wrote: > > > Why can't we not use err(), warn(), etc. from err.h? > > It's not necessary and introduces more problems, as it forces a certain > format on the error-messages, always beginning with "qu

Re: [dev][PATCH][quark] Clean up the log-facility [fixed-PATCH]

2014-03-03 Thread FRIGN
On Mon, 3 Mar 2014 21:16:46 + sin wrote: > Why can't we not use err(), warn(), etc. from err.h? It's not necessary and introduces more problems, as it forces a certain format on the error-messages, always beginning with "quark:". I'm all for using built-in functions, but in this case, it's n

Re: [dev][PATCH][quark] Clean up the log-facility

2014-03-03 Thread koneu
On March 3, 2014 10:16:46 PM CET, sin wrote: >On Mon, Mar 03, 2014 at 07:39:13PM +0100, FRIGN wrote: >> I'm currently working on quark and would like to propose a patch >> simplifying the logmsg-, logerrmsg- and die-functions in quark. >> There's more to come! > >Why can't we not use err(), warn()

Re: [dev][PATCH][quark] Clean up the log-facility

2014-03-03 Thread FRIGN
On Mon, 3 Mar 2014 22:02:26 +0100 Szabolcs Nagy wrote: > note that stdlib.h may include math.h which declares log > with a different type Thanks, I didn't notice that, as I'm using musl to compile it. Using glibc: > quark.c:70:13: warning: conflicting types for built-in function

Re: [dev][PATCH][quark] Clean up the log-facility

2014-03-03 Thread sin
On Mon, Mar 03, 2014 at 07:39:13PM +0100, FRIGN wrote: > I'm currently working on quark and would like to propose a patch > simplifying the logmsg-, logerrmsg- and die-functions in quark. > There's more to come! Why can't we not use err(), warn(), etc. from err.h?

Re: [dev][PATCH][quark] Clean up the log-facility

2014-03-03 Thread Szabolcs Nagy
* FRIGN [2014-03-03 19:39:13 +0100]: > +static void log(int type, const char *errstr, ...); note that stdlib.h may include math.h which declares log with a different type such namespace issues can be fixed by using another name or #undef log #define log quark_log after the header includes an

[dev][PATCH][quark] Clean up the log-facility

2014-03-03 Thread FRIGN
Good evening, I'm currently working on quark and would like to propose a patch simplifying the logmsg-, logerrmsg- and die-functions in quark. There's more to come! Cheers FRIGN @sin: Now generated with git format-patch ;) -- FRIGN >From 77a72d1e41c92b9ddbe6b51f5ac2a7ffecf39c4b Mon Sep 17 00