Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode

2011-07-20 Thread garbeam
Hi Peter, On 11 July 2011 01:02, Peter John Hartman peterjohnhart...@gmail.com wrote: Actually, this bug goes way back, but I thought I'd be the first to report it, just to ruin dwm's birthday.  The culprit is this chunk of code in manage():        if(c-w == c-mon-mw c-h == c-mon-mh) {    

Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode

2011-07-20 Thread Hiltjo Posthuma
On Wed, Jul 20, 2011 at 8:39 PM, garbeam garb...@gmail.com wrote: Current discussion on the mailing list is leaning to just eliminating that chunk of code.  Apparently, flash fullscreen requires it (which I haven't been able to reproduce!)  But why on earth is that code there, and can't flash

Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode

2011-07-20 Thread Peter John Hartman
I can reproduce that fullscreen flash requires this. Flash creates a new window with unknown title and class and sets the _NET_WM_FULLSCREEN property. Maybe as a solution it makes sense to check for _NET_WM_FULLSCREEN property in manage() and set c-isfullscreen (and modify some layout

[dev] [dwm] [bug] 5.9's first bug: magic float mode

2011-07-10 Thread Peter John Hartman
Hi, Actually, this bug goes way back, but I thought I'd be the first to report it, just to ruin dwm's birthday. The culprit is this chunk of code in manage(): if(c-w == c-mon-mw c-h == c-mon-mh) { // c-isfloating = True; pjh c-x = c-mon-mx;