Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-11 Thread StephenB
On 11 August 2010 14:25, Connor Lane Smith wrote: > > That was a lie. The patch fails as of r357. I'm sure it will be easy to fix, I'll have a look later tonight, as well as pushing it to the wiki. StephenB

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-11 Thread Connor Lane Smith
> 4.2 should be released soon, yes. The code affected probably won't be > changed at all between now and then, so the patch shouldn't get > rejected. That was a lie. The patch fails as of r357. cls

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-10 Thread Connor Lane Smith
On 9 August 2010 22:35, StephenB wrote: > I think I read in a previous post that there may be a dmenu release sometime > soon. I can make sure that Conner's version of the patch works with that. > (in the mean time I will back port Conner's to 4.1.1 (latest stable) and put > a pkg on AUR, I will p

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-10 Thread Dieter Plaetinck
On Tue, 10 Aug 2010 03:20:57 +0200 Arian Kuschki wrote: > Excerpts from Uriel's message of 2010-08-10 02:01:40 +0200: > > This seems like a rather clumsy, non-standard and silly way to > > implement globbing. > > > > Implementing * and ? wildcards would be a much better idea. > > I've been usin

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-09 Thread Arian Kuschki
Excerpts from Uriel's message of 2010-08-10 02:01:40 +0200: > This seems like a rather clumsy, non-standard and silly way to > implement globbing. > > Implementing * and ? wildcards would be a much better idea. I've been using the original patch for a while already and I find it easier and quicke

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-09 Thread Uriel
This seems like a rather clumsy, non-standard and silly way to implement globbing. Implementing * and ? wildcards would be a much better idea. uriel On Sat, Aug 7, 2010 at 3:20 PM, StephenB wrote: > see: (this patch is against 352) > http://pastebin.com/raw.php?i=4sh7ZTuJ > I use this all the t

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-09 Thread StephenB
Corrected missing .TP in man source. On 9 August 2010 22:35, StephenB wrote: > On 9 August 2010 12:26, Connor Lane Smith wrote: > >> Thanks for the patch, Stephen. One small bug, however: the added flag >> should be above the first usage(), since it is a single flag (it takes >> no value). If y

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-09 Thread StephenB
On 9 August 2010 12:26, Connor Lane Smith wrote: > Thanks for the patch, Stephen. One small bug, however: the added flag > should be above the first usage(), since it is a single flag (it takes > no value). If you try to run "dmenu_run -xs" it will fail because it > expects another argument. You

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-09 Thread Connor Lane Smith
Hey, Thanks for the patch, Stephen. One small bug, however: the added flag should be above the first usage(), since it is a single flag (it takes no value). If you try to run "dmenu_run -xs" it will fail because it expects another argument. On 8 August 2010 15:15, Dieter Plaetinck wrote: > this

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-08 Thread Dieter Plaetinck
On Sat, 7 Aug 2010 22:27:31 +0100 StephenB wrote: > On 7 August 2010 20:36, Robert Ransom wrote: > > > On Sat, 7 Aug 2010 17:23:13 +0100 > > StephenB wrote: > > > > > Just to make clear, this patch is an updated version of the one > > > here: > > > http://tools.suckless.org/dmenu/patches/xmms-

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-07 Thread StephenB
On 7 August 2010 20:36, Robert Ransom wrote: > On Sat, 7 Aug 2010 17:23:13 +0100 > StephenB wrote: > > > Just to make clear, this patch is an updated version of the one here: > > http://tools.suckless.org/dmenu/patches/xmms-like_pattern_matching > > http://suckless.org/wiki/ > > > Robert Ransom

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-07 Thread Robert Ransom
On Sat, 7 Aug 2010 17:23:13 +0100 StephenB wrote: > Just to make clear, this patch is an updated version of the one here: > http://tools.suckless.org/dmenu/patches/xmms-like_pattern_matching http://suckless.org/wiki/ Robert Ransom signature.asc Description: PGP signature

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-07 Thread StephenB
On 7 August 2010 14:25, Rob wrote: > Uh, in tokenise, shouldn't > strncpy(tmp, pat, strlen(pat)); > be > strncpy(tmp, pat, sizeof tmp); ? we only tokenise text, so it can simplify to: unsigned int tokenize(char **tok) { unsigned int i = 0; char tmp[sizeof text] = {0}; strcpy(tmp, text); I als

Re: [dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-07 Thread Rob
Uh, in tokenise, shouldn't strncpy(tmp, pat, strlen(pat)); be strncpy(tmp, pat, sizeof tmp); ? On 7 August 2010 14:20, StephenB wrote: > see: (this patch is against 352) > http://pastebin.com/raw.php?i=4sh7ZTuJ > I use this all the time for uzbl browser history and bookmarks. > regards, > Stephen

[dev] [patch] xmms like pattern matching for dmenu (update to hg tip)

2010-08-07 Thread StephenB
see: (this patch is against 352) http://pastebin.com/raw.php?i=4sh7ZTuJ I use this all the time for uzbl browser history and bookmarks. regards, StephenB