Re: [dev] [sbase][PATCH v2] diff

2016-01-31 Thread Mattias Andrée
On Sun, 31 Jan 2016 12:39:34 +0100 Hiltjo Posthuma wrote: > Some notes from me: > > - I would avoid using variadic arrays, use a sane subset > of C99. Are you refering to this code? #define matrix (*matrix) #define map (*map) char map[an + 1][bn + 1] = emalloc(sizeof(char[an + 1][bn + 1]

Re: [dev] [sbase][PATCH v2] diff

2016-01-31 Thread Hiltjo Posthuma
On Sat, Jan 30, 2016 at 4:13 PM, Mattias Andrée wrote: > New command. Should be POSIX-compliant. > > Extensions to POSIX: > > 1) In directories, sockets are not compared. > POSIX specifies that special devices and FIFO:s > shall never be compared, and that for other types > than these

[dev] [sbase][PATCH v2] diff

2016-01-30 Thread Mattias Andrée
New command. Should be POSIX-compliant. Extensions to POSIX: 1) In directories, sockets are not compared. POSIX specifies that special devices and FIFO:s shall never be compared, and that for other types than these and regular files and directories, it is implementation-specified