Re: [dev] [sdhcp] Part 1/3 Bugs

2018-11-14 Thread Sean MacLennan
On Wed, 14 Nov 2018 17:13:15 -0800 Michael Forney wrote: > On 2018-11-12, Sean MacLennan wrote: > > I am surprised you are getting away with binding the socket to the > > broadcast address. > > I found in ip(7): > > INADDR_BROADCAST (255.255.255.255) means any host and has the same > eff

Re: [dev] [sdhcp] Part 1/3 Bugs

2018-11-14 Thread Michael Forney
On 2018-11-12, Sean MacLennan wrote: > I am surprised you are getting away with binding the socket to the > broadcast address. I found in ip(7): INADDR_BROADCAST (255.255.255.255) means any host and has the same effect on bind as INADDR_ANY for historical reasons. So that explains why it wo

[dev] [sdhcp] Part 1/3 Bugs

2018-11-12 Thread Sean MacLennan
I am surprised you are getting away with binding the socket to the broadcast address. The other bug is just a simple compiler warning. diff --git a/sdhcp.c b/sdhcp.c index e2a641e..47cabf6 100644 --- a/sdhcp.c +++ b/sdhcp.c @@ -467,7 +467,7 @@ main(int argc, char *argv[]) if (argc)