Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-09-13 Thread Roberto E. Vargas Caballero
> I'm fairly certain that we are supposed to always add 32 unless in SGR > mode. I've just now confirmed with the xterm (version 296) source code: Ok, patch applied. Thanks!. -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-09-13 Thread Michael Forney
On Thu, 01 Aug 2013 10:10:23 +0200, "Roberto E. Vargas Caballero" wrote: > > This suggests that we should still add 32 to the button value when in > > MODE_MOUSEX10. > > It is no clear for me if we have to add it or not, did you test it with > other emulators? Hi, I apologize for the delay

Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-08-01 Thread Roberto E. Vargas Caballero
> * Button number in X10 mode: > > I believe the button - 1 came from "C b is button - 1" from [0]. > However, above this section, it states > > "Normally, parameters (such as pointer poisition and button number) > for all mouse tracking escape sequences generated by xterm encode >

[dev] [st] [PATCH] Fix some bugs in mouse tracking logic

2013-07-25 Thread Michael Forney
* Button number in X10 mode: I believe the button - 1 came from "C b is button - 1" from [0]. However, above this section, it states "Normally, parameters (such as pointer poisition and button number) for all mouse tracking escape sequences generated by xterm encode numeric para