> I've done this, but I'm not sure it reads as well. The existing
> version first checks the *kp fields because if they are zero, the is
> no need to peek at term.mode.
>
I have tested the patches and they seem correct and I have applied
them. If there is some problem, I hope someone can catch it
Sorry for the delay, but I am very busy lately :S.
> Note that match() is used in four places, so I can't merge it into kmap().
You are right and I suck. When I wrote this function it was
a part of kmap which became too much complex, so I put the code
in a new function, and I didn't know other gu
On Sun, Oct 20, 2013 at 9:51 AM, Roberto E. Vargas Caballero
wrote:
> I think this patch is correct, because XK_NO_MOD is 0, so if there is
> some modifier then 'state == mask' will be false. After the simplification,
> match is too short and does nothing, so I think it should be
> merged into km
On Sun, Oct 20, 2013 at 9:51 AM, Roberto E. Vargas Caballero
wrote:
> Please send atomic patches
Sorry for the mess, I've broken these changes out now.
> In this case the tab part is not correct, because we use
> smart tabs in the project, tabs for indentation and spaces for
> alignment.
Yes, m
Greetings.
On Sun, 20 Oct 2013 18:05:09 +0200 Mark Edgar wrote:
> However, since (I'm assuming) the only point of mappedkeys[] or
> sorting key[] is for performance, and since there is no measurable
> performance difference among these three versions, I think the
> simplest code should win. Of co
On Sat, Oct 19, 2013 at 12:43 PM, Alexander S. wrote:
> Why removing mappedkeys? Sure, there may be no visible regression, but
> checking every keypress against key bindings seems unreasonable to me.
On Sun, Oct 20, 2013 at 9:11 AM, Roberto E. Vargas Caballero
wrote:
> I don't like the actual so
>The first patch is purely aesthetic: it cleans up column headings
>(comments) and internal tabs in the shortcuts/key/mshortcuts tables in
>config.def.h. It also renames the fields in Key to match the nicer names
>given in config.def.h.
Please send atomic patches, The patch must do
> > The third patch simplifies the matching logic in kmap() and match() without
> > changing the behavior. Hopefully, it is straightforward, but it probably
> > deserves a careful reading to make sure I haven't made any mistakes.
> Why removing mappedkeys? Sure, there may be no visible regression,
2013/10/19 Mark Edgar :
> A series of patches for consideration.
>
> The first patch is purely aesthetic: it cleans up column headings (comments)
> and internal tabs in the shortcuts/key/mshortcuts tables in config.def.h. It
> also renames the fields in Key to match the nicer names given in
> confi
A series of patches for consideration.
The first patch is purely aesthetic: it cleans up column headings
(comments) and internal tabs in the shortcuts/key/mshortcuts tables in
config.def.h. It also renames the fields in Key to match the nicer names
given in config.def.h.
The second patch removes
10 matches
Mail list logo
