Re: [dev] [st] minor issue and scrollback patch

2016-04-10 Thread Mitt Green
Bryan Bennett wrote: Unless I'm reading this improperly, the cursor's color would still change because of the if-block between line 3858 and ~3875. Even if the colour changes, I can't see it. It looks like you could simply remove the if-statement that Pickfire is mentioning entirely and

Re: [dev] [st] minor issue and scrollback patch

2016-04-10 Thread Bryan Bennett
Unless I'm reading this improperly, the cursor's color would still change because of the if-block between line 3858 and ~3875. It looks like you could simply remove the if-statement that Pickfire is mentioning entirely and structure it so that it always uses the "if" case.

Re: [dev] [st] minor issue and scrollback patch

2016-04-08 Thread Pickfire
On Fri, Apr 08, 2016 at 10:26:38PM +0300, Mitt Green wrote: Draco Metallium wrote: Did you ever change config.def.h? By hand or maybe with another patch? I did, by hand, after first clone from git. You know, there was no config.h, so instead of copying config.def.h, I changed the latter.

Re: [dev] [st] minor issue and scrollback patch

2016-04-08 Thread Mitt Green
Draco Metallium wrote: Did you ever change config.def.h? By hand or maybe with another patch? I did, by hand, after first clone from git. You know, there was no config.h, so instead of copying config.def.h, I changed the latter. If so, just add "#define histsize 2000" to it (just after

Re: [dev] [st] minor issue and scrollback patch

2016-04-08 Thread Rodrigo S. CaƱibano
> 2) Trying to apply the patch [1] leads to: > > patching file config.h > HUNK #1 failed at 7 Did you ever change config.def.h? By hand or maybe with another patch? If so, just add "#define histsize 2000" to it (just after "static int borderpx..."), and compile. Remember to remove

[dev] [st] minor issue and scrollback patch

2016-04-08 Thread Mitt Green
Hi everyone, 1) In st I use underline as a cursor, but whatever cursor I choose, on inactive window there is always an empty block. 2) Trying to apply the patch [1] leads to: patching file config.h HUNK #1 failed at 7 ... [I changed config.def.h to config.h, but even if not, it