Re: [dev] [surf] [PATCH] improve title change handling

2014-02-13 Thread Quentin Rameau
> I'm weary about ifdef statements and it doesn't look like this would > handle future versions of webkit anyway. Yes, I'm not fond either of defining use cases with preprocessor statements, that's why I'm rather asking if we should keep the if check (as it is only useful for outdated versions of

Re: [dev] [surf] [PATCH] improve title change handling

2014-02-09 Thread Carlos Torres
I'm weary about ifdef statements and it doesn't look like this would handle future versions of webkit anyway. --Carlos On 2/9/14, Quentin Rameau wrote: > Here is another patch, I'm not sure we should handle multiple versions > of webkitgtk. But as this bug is corrected in newer (recent, stable)

Re: [dev] [surf] [PATCH] improve title change handling

2014-02-09 Thread Quentin Rameau
Here is another patch, I'm not sure we should handle multiple versions of webkitgtk. But as this bug is corrected in newer (recent, stable) versions of webkitgtk, should we remove the needless workaround and assume user has a valid version of webkitgtk ? 0001-Webkitgtk-1.11.5-fixes-anchor-title-h

[dev] [surf] [PATCH] improve title change handling

2014-02-08 Thread Quentin Rameau
This patch prevents title from being empty when following an anchor within a page. I'm don't think it breaks anything else, but of course I could be wrong. 0001-Prevent-title-from-being-empty-when-following-an-anc.patch Description: Binary data