Re: [dev] Re: [sbase] [PATCH] sort: Fix -u option

2016-03-13 Thread Dimitris Papastamos
On Sat, Mar 12, 2016 at 03:48:13PM -0800, Michael Forney wrote: > On Sat, Mar 12, 2016 at 11:46:31AM -0800, Michael Forney wrote: > > In eb9bda878736344d1bef06d42e57e96de542a663, a bug was introduced in the > > handling of -1 return values from getline. Since the type of the len > > field in struct

[dev] Re: [sbase] [PATCH] sort: Fix -u option

2016-03-12 Thread Michael Forney
On Sat, Mar 12, 2016 at 11:46:31AM -0800, Michael Forney wrote: > In eb9bda878736344d1bef06d42e57e96de542a663, a bug was introduced in the > handling of -1 return values from getline. Since the type of the len > field in struct line is unsigned, the break condition was never true. > This caused sor