[RESULT][VOTE]: Proposal to introduce Flask app factory pattern

2021-04-28 Thread Craig Rueda
The vote has now closed. The results are: *7* binding +1s The vote is *successful.* *Binding* votes in favor: Daniel Gaspar Ville Brofeldt Rob DiCiuccio John Bodley Maxime Beauchemin Will Barrett Craig Rueda There were no 0 or -1 votes! Thanks everyone! -Craig

Re: [VOTE][SIP-24]: Proposal to introduce Flask app factory pattern

2021-04-28 Thread Craig Rueda
+1 binding On Tue, Apr 27, 2021 at 1:33 AM Daniel Gaspar wrote: > +1 binding > > On 2021/04/22 02:14:15, Craig Rueda wrote: > > Hello Superset Community, > > > > This is another *very belated* call to vote for a SIP -- SIP-24 - > Proposal > > to introduce Flask app factory pattern: > >

Re: [DISCUSS] Proposal: Wiki pages for coding style guidelines and coding best practices

2021-04-28 Thread Beto Dealmeida
Love the idea, and I volunteer to write the SIP-40/41 guidelines, since I already have something written internally at Preset. --Beto On 4/27/21 10:25 PM, Evan Rusackas wrote: Greetings everyone! Inspired by conversations in the community, and by a similar process beginning to take shape in

Re: [DISCUSS] Proposal: Wiki pages for coding style guidelines and coding best practices

2021-04-28 Thread Srinivasa Kadamati
Evan, This is a great idea! I wonder, more generally speaking, if we could move CONTRIBUTING.MD into the wiki on Github and turn it into a one-stop shop for getting started on the contribution process? It would be great to make the contribution on-ramp easier, and having a clean wiki we can