Re: [VOTE] Release Apache Superset 1.3.1 based on Superset 1.3.1rc1

2021-09-07 Thread Elizabeth Thompson
I’m so glad to see a patch release follow up to 1.3.0. I feel though that if we truly wanted to call this a patch/fix release that it should only have bug fixes and no features. I would propose to only include the fixes and leave the feature cherries for 1.4.0. Elizabeth > On Sep 7, 2021, at

Re: [VOTE] Release Apache Superset 1.3.1 based on Superset 1.3.1rc1

2021-09-07 Thread Ville Brofeldt
Hi all, Sure thing, happy to kick off an rc2 with #16258. However, AFAIK it only affects Presto, so rc1 should still be fine on other connections. So I’ll leave the rc open for a while longer, and will bake rc2 later this week if other important bugs/fixes surface. Ville > On 7. Sep 2021, at

Re: [VOTE] Release Apache Superset 1.3.1 based on Superset 1.3.1rc1

2021-09-07 Thread Erik Ritter
-1, as this is missing a pretty big cherry just fixed by Ville himself! I'd recommend recutting a branch with https://github.com/apache/superset/pull/16614 added that resolves https://github.com/apache/superset/issues/16258. Best, Erik On Tue, Sep 7, 2021 at 4:11 AM Yongjie wrote: > +1

Re: [VOTE] Release Apache Superset 1.3.1 based on Superset 1.3.1rc1

2021-09-07 Thread Craig Rueda
+1 - Craig > On Sep 7, 2021, at 4:11 AM, Yongjie wrote: > > +1 (binding) > >> On Mon, Sep 6, 2021 at 9:11 PM Ville Brofeldt >> wrote: >> >> FYI, the image is now also available on docker hub: >> >> >>

Re: [VOTE] Release Apache Superset 1.3.1 based on Superset 1.3.1rc1

2021-09-07 Thread Yongjie
+1 (binding) On Mon, Sep 6, 2021 at 9:11 PM Ville Brofeldt wrote: > FYI, the image is now also available on docker hub: > > > https://hub.docker.com/layers/apache/superset/1.3.1rc1-dev/images/sha256-8f459c1568650201d99fc76d84bdfcc2a5358e0ac25e96143bf01c9d1481df49?context=explore > > Ville > >