Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Hugh Miles
+1 (non-binding) Checked: - Database Creation - Sqllab (running query, setting schema + table, creating dataset) - Creating a chart - Adding chart to dashboard - Dashboard to explore/chart view H. Miles On Fri, Jan 14, 2022 at 1:56 PM, Elizabeth Thompson wrote: > Hello Superset Community, >

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Tai Dupree
An easy way to verify this is by comparing the commit on the rc branch vs the commit on master. On master the commit is essentially a 1 line change, while on the rc that commit is much larger and does not touch the same files. Master commit:

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Tai Dupree
Actually, I just noticed something. Looks like in the RC these two commits were cherry-picked in a reverse order: https://github.com/apache/superset/commit/4c00bd4332860912ddecfa9ca02927b514621e3d https://github.com/apache/superset/commit/ba6d5b97542cbe8cfad5fec1e1e08e1992a0b78e on the master

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Srinivasa Kadamati
+1 (binding) Stress tested & Checked all of the common user flows! Excited for this On Wed, Jan 12, 2022 at 8:28 PM wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 1.4.0. > > The release candidate: >