Re: [RESULT][VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-22 Thread Ville Brofeldt
FYI, I think both Tai's and my votes could be considered binding, as we're both PMCs (probably a good idea to add "binding" in the vote in the future to make it easier for the final count). > On Apr 22, 2024, at 10:37 AM, Justin Park wrote: > > Hi All, > > Thanks to everyone who voted and par

[RESULT][VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-22 Thread Justin Park
Hi All, Thanks to everyone who voted and participated in the discussion! The vote has PASSED with 4 binding +1, 4 non-binding + 1 and 0 -1 votes. Binding +1 votes: - Evan - Elizabeth - Michael - Sam Non-binding +1 votes: - Cubenshi - Antonio - Ville - Tai There were no 0 or -1 votes. The vote

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Sam Firke
This sounded dull because I was unfamiliar with the terms. Then I opened the SIP and it looks awesome! That's a nicely done SIP, thanks for the write-up. +1 binding On Tue, Apr 16, 2024, at 8:51 PM, Michael S. Molina wrote: > +1 (binding) > > Best regards, > Michael S. Molina > > > On 16 Apr 2

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Tai Dupree
+1! On Tue, Apr 16, 2024 at 5:51 PM Michael S. Molina < michael.s.mol...@gmail.com> wrote: > +1 (binding) > > Best regards, > Michael S. Molina > > > On 16 Apr 2024, at 21:39, Ville Brofeldt > wrote: > > > > Hi, > > > > this SIP had gone unnoticed by me. But after reading through it I'm > super

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Michael S. Molina
+1 (binding) Best regards, Michael S. Molina > On 16 Apr 2024, at 21:39, Ville Brofeldt wrote: > > Hi, > > this SIP had gone unnoticed by me. But after reading through it I'm super > excited to see this moving forward, and I think this will have a huge impact > on the Superset UX. So big +1

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Ville Brofeldt
Hi, this SIP had gone unnoticed by me. But after reading through it I'm super excited to see this moving forward, and I think this will have a huge impact on the Superset UX. So big +1 from me. Ville > On Apr 16, 2024, at 11:41 AM, Justin Park wrote: > > Hi, > > Following up from the corres

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Antonio Rivero
bril de 2024 12:41 p. m. >> Para: dev@superset.apache.org >> Asunto: [VOTE][SIP-123] Proposal replacement of data table components with >> ag-grid >> >> Hi, >> >> Following up from the corresponding DISCUSS email I sent on April 9th, I >> was hop

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Elizabeth Thompson
+1 binding > On Apr 16, 2024, at 4:16 PM, Cubenshi Mimidenshi wrote: > > + 1 > > De: Justin Park > Enviado: martes, 16 de abril de 2024 12:41 p. m. > Para: dev@superset.apache.org > Asunto: [VOTE][SIP-123] Proposal replacement of da

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Cubenshi Mimidenshi
+ 1 De: Justin Park Enviado: martes, 16 de abril de 2024 12:41 p. m. Para: dev@superset.apache.org Asunto: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid Hi, Following up from the corresponding DISCUSS email I sent on April 9th, I

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Evan Rusackas
+1 (binding) On Apr 16, 2024 at 12:41 PM -0600, Justin Park , wrote: > Hi, > > Following up from the corresponding DISCUSS email I sent on April 9th, I > was hoping to call a vote on [SIP-123] Proposal replacement of data table > components with ag-grid as detailed below: > https://github.com/apach

[VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Justin Park
Hi, Following up from the corresponding DISCUSS email I sent on April 9th, I was hoping to call a vote on [SIP-123] Proposal replacement of data table components with ag-grid as detailed below: https://github.com/apache/superset/issues/27645 The vote will be open for at least 72 hours or until th