[GitHub] mistercrunch commented on issue #3211: [WiP] prevent XSS markup viz

2017-08-09 Thread git
mistercrunch commented on issue #3211: [WiP] prevent XSS markup viz URL: https://github.com/apache/incubator-superset/pull/3211#issuecomment-321175800 https://github.com/apache/incubator-superset/pull/3262 should unblock this effort ---

[GitHub] mistercrunch opened a new pull request #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
mistercrunch opened a new pull request #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262 * cleaning up some templates * fix manifest getting parse at every request @graceguo-supercat

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321179983 [![Coverage Status](https://coveralls.io/builds/12756258/badge)](https://coveralls.io/builds/12756258) Covera

[GitHub] rezabaktash opened a new issue #3263: SQL Lab does not load temp table names in spark SQL

2017-08-09 Thread git
rezabaktash opened a new issue #3263: SQL Lab does not load temp table names in spark SQL URL: https://github.com/apache/incubator-superset/issues/3263 Hi, I am using Superset 0.19.0 to connect Spark Sql. I need to query my temp tables in spark. The database is created and connection i

[GitHub] cclauss opened a new pull request #3264: import logging

2017-08-09 Thread git
cclauss opened a new pull request #3264: import logging URL: https://github.com/apache/incubator-superset/pull/3264 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] coveralls commented on issue #3264: import logging

2017-08-09 Thread git
coveralls commented on issue #3264: import logging URL: https://github.com/apache/incubator-superset/pull/3264#issuecomment-321198420 [![Coverage Status](https://coveralls.io/builds/12757267/badge)](https://coveralls.io/builds/12757267) Coverage remained the same at 69.311% when

[GitHub] amoussoubaruch commented on issue #3221: Airbnb Superset LDAP authentication with Active Directory

2017-08-09 Thread git
amoussoubaruch commented on issue #3221: Airbnb Superset LDAP authentication with Active Directory URL: https://github.com/apache/incubator-superset/issues/3221#issuecomment-320985089 Hi, I have same issue. I use also followed the oficial docs instructions. But i get this error. I don'

[GitHub] Aung-Myint-Thein commented on issue #2340: How to use github oauth?

2017-08-09 Thread git
Aung-Myint-Thein commented on issue #2340: How to use github oauth? URL: https://github.com/apache/incubator-superset/issues/2340#issuecomment-321214829 Hi I managed to set it up and wrote a post here. https://medium.com/@aungmt/superset-with-google-oauth-3ba7a1c1f459 -

[GitHub] Aung-Myint-Thein commented on issue #755: How to use google OAuth in caravel

2017-08-09 Thread git
Aung-Myint-Thein commented on issue #755: How to use google OAuth in caravel URL: https://github.com/apache/incubator-superset/issues/755#issuecomment-321214933 Managed to set it up after reading source codes on both Superset and Flask_appbuilder. https://medium.com/@aungmt/superset

[GitHub] coveralls commented on issue #3220: Js translation

2017-08-09 Thread git
coveralls commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-321247429 [![Coverage Status](https://coveralls.io/builds/12760143/badge)](https://coveralls.io/builds/12760143) Coverage increased (+0.003%) to 69.314% wh

[GitHub] coveralls commented on issue #3220: Js translation

2017-08-09 Thread git
coveralls commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-321247427 [![Coverage Status](https://coveralls.io/builds/12760143/badge)](https://coveralls.io/builds/12760143) Coverage increased (+0.003%) to 69.314% wh

[GitHub] coveralls commented on issue #3220: Js translation

2017-08-09 Thread git
coveralls commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-321250699 [![Coverage Status](https://coveralls.io/builds/12760288/badge)](https://coveralls.io/builds/12760288) Coverage increased (+0.003%) to 69.314% wh

[GitHub] kumarit commented on issue #2156: [sqllab] Multiple Statement Queries

2017-08-09 Thread git
kumarit commented on issue #2156: [sqllab] Multiple Statement Queries URL: https://github.com/apache/incubator-superset/issues/2156#issuecomment-321264818 after establish the connection between kylin and superset, i am trying to use sqllab for fetching the table from kylin to do visualizat

[GitHub] amoussoubaruch commented on issue #3221: Airbnb Superset LDAP authentication with Active Directory

2017-08-09 Thread git
amoussoubaruch commented on issue #3221: Airbnb Superset LDAP authentication with Active Directory URL: https://github.com/apache/incubator-superset/issues/3221#issuecomment-321274348 @mauriciozambretti I have same issue. Have you find any solution for Ldap connexion? Thank

[GitHub] mistercrunch closed issue #3221: Apache Superset LDAP authentication with Active Directory

2017-08-09 Thread git
mistercrunch closed issue #3221: Apache Superset LDAP authentication with Active Directory URL: https://github.com/apache/incubator-superset/issues/3221 This is an automated message from the Apache Git Service. To respond t

[GitHub] mistercrunch commented on issue #3221: Apache Superset LDAP authentication with Active Directory

2017-08-09 Thread git
mistercrunch commented on issue #3221: Apache Superset LDAP authentication with Active Directory URL: https://github.com/apache/incubator-superset/issues/3221#issuecomment-321286283 You should open an issue on the FAB side https://github.com/dpgaspar/Flask-AppBuilder -

[GitHub] mistercrunch commented on issue #2156: [sqllab] Multiple Statement Queries

2017-08-09 Thread git
mistercrunch commented on issue #2156: [sqllab] Multiple Statement Queries URL: https://github.com/apache/incubator-superset/issues/2156#issuecomment-321286756 @kumarit this seems unrelated to this issue. You should open another issue. -

[GitHub] mistercrunch commented on issue #2156: [sqllab] Multiple Statement Queries

2017-08-09 Thread git
mistercrunch commented on issue #2156: [sqllab] Multiple Statement Queries URL: https://github.com/apache/incubator-superset/issues/2156#issuecomment-321286756 @kumarit this seems unrelated to this issue. You should open another issue. Also most likely related to you SQLAlchemy connection

[GitHub] mistercrunch closed pull request #3264: import logging

2017-08-09 Thread git
mistercrunch closed pull request #3264: import logging URL: https://github.com/apache/incubator-superset/pull/3264 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321295276 [![Coverage Status](https://coveralls.io/builds/12762859/badge)](https://coveralls.io/builds/12762859) Covera

[GitHub] mistercrunch commented on issue #3258: Allow for multiple color schemes

2017-08-09 Thread git
mistercrunch commented on issue #3258: Allow for multiple color schemes URL: https://github.com/apache/incubator-superset/issues/3258#issuecomment-321297781 For reference: https://bl.ocks.org/mbostock/5577023 http://bl.ocks.org/aaizemberg/78bd3dade9593896a59d ---

[GitHub] mistercrunch commented on issue #3258: Allow for multiple color schemes

2017-08-09 Thread git
mistercrunch commented on issue #3258: Allow for multiple color schemes URL: https://github.com/apache/incubator-superset/issues/3258#issuecomment-321298777 Also perhaps in scope, using the same new control component for linear colors: https://github.com/apache/incubator-superset/blob/

[GitHub] mistercrunch closed pull request #3261: Relying on FAB for font-awesome.min.css

2017-08-09 Thread git
mistercrunch closed pull request #3261: Relying on FAB for font-awesome.min.css URL: https://github.com/apache/incubator-superset/pull/3261 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mistercrunch commented on issue #3252: Flask as dependancy

2017-08-09 Thread git
mistercrunch commented on issue #3252: Flask as dependancy URL: https://github.com/apache/incubator-superset/pull/3252#issuecomment-321302951 Thought about this some more and I think it's a good thing to pin Flask in the context of Superset. --

[GitHub] mistercrunch closed pull request #3252: Flask as dependancy

2017-08-09 Thread git
mistercrunch closed pull request #3252: Flask as dependancy URL: https://github.com/apache/incubator-superset/pull/3252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] mistercrunch closed pull request #3256: Modernize SQLA pessimistic handling

2017-08-09 Thread git
mistercrunch closed pull request #3256: Modernize SQLA pessimistic handling URL: https://github.com/apache/incubator-superset/pull/3256 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] mistercrunch closed pull request #3241: Improve the chart type of Visualize in sqllab

2017-08-09 Thread git
mistercrunch closed pull request #3241: Improve the chart type of Visualize in sqllab URL: https://github.com/apache/incubator-superset/pull/3241 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] mistercrunch commented on a change in pull request #3183: [add] Save filters to dashboard

2017-08-09 Thread git
mistercrunch commented on a change in pull request #3183: [add] Save filters to dashboard URL: https://github.com/apache/incubator-superset/pull/3183#discussion_r132232608 ## File path: superset/models/core.py ## @@ -322,6 +323,18 @@ def table_names(self): @propert

[GitHub] mistercrunch commented on a change in pull request #3183: [add] Save filters to dashboard

2017-08-09 Thread git
mistercrunch commented on a change in pull request #3183: [add] Save filters to dashboard URL: https://github.com/apache/incubator-superset/pull/3183#discussion_r132234242 ## File path: superset/assets/javascripts/dashboard/Dashboard.jsx ## @@ -195,6 +199,13 @@ export fun

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321308030 [![Coverage Status](https://coveralls.io/builds/12763762/badge)](https://coveralls.io/builds/12763762) Covera

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321308026 [![Coverage Status](https://coveralls.io/builds/12763762/badge)](https://coveralls.io/builds/12763762) Covera

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321308029 [![Coverage Status](https://coveralls.io/builds/12763762/badge)](https://coveralls.io/builds/12763762) Covera

[GitHub] mistercrunch commented on a change in pull request #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
mistercrunch commented on a change in pull request #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#discussion_r132235404 ## File path: superset/__init__.py ## @@ -32,19 +32,21 @@ app.config.from_object(

[GitHub] coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
coveralls commented on issue #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262#issuecomment-321313706 [![Coverage Status](https://coveralls.io/builds/12764183/badge)](https://coveralls.io/builds/12764183) Covera

[GitHub] Fokko commented on issue #3252: Flask as dependancy

2017-08-09 Thread git
Fokko commented on issue #3252: Flask as dependancy URL: https://github.com/apache/incubator-superset/pull/3252#issuecomment-321314877 Hi Maxime, Thanks for merging the PR. When looked online for similar issues, the closest one I can find is this one: https://github.com/pallets/f

[GitHub] mistercrunch closed pull request #3262: [webpack] break CSS and JS files while webpackin'

2017-08-09 Thread git
mistercrunch closed pull request #3262: [webpack] break CSS and JS files while webpackin' URL: https://github.com/apache/incubator-superset/pull/3262 This is an automated message from the Apache Git Service. To respond to t

[GitHub] vibinsv09 opened a new issue #3265: Refresh table definition

2017-08-09 Thread git
vibinsv09 opened a new issue #3265: Refresh table definition URL: https://github.com/apache/incubator-superset/issues/3265 Does superset allow to refresh table definition? If I add new columns to the table in Database, how do I refresh the definition to import the new columns without add

[GitHub] Fokko opened a new pull request #3266: Pre fill Druid ports

2017-08-09 Thread git
Fokko opened a new pull request #3266: Pre fill Druid ports URL: https://github.com/apache/incubator-superset/pull/3266 Hi all, For Druid set the default port for the broker and coordinator: ![image](https://user-images.githubusercontent.com/1134248/29136216-e0263378-7d3c-11e7-9bf

[GitHub] coveralls commented on issue #3266: Pre fill Druid ports

2017-08-09 Thread git
coveralls commented on issue #3266: Pre fill Druid ports URL: https://github.com/apache/incubator-superset/pull/3266#issuecomment-321339590 [![Coverage Status](https://coveralls.io/builds/12765610/badge)](https://coveralls.io/builds/12765610) Coverage decreased (-0.02%) to 69.28

[GitHub] coveralls commented on issue #3266: Pre fill Druid ports

2017-08-09 Thread git
coveralls commented on issue #3266: Pre fill Druid ports URL: https://github.com/apache/incubator-superset/pull/3266#issuecomment-321339590 [![Coverage Status](https://coveralls.io/builds/12765610/badge)](https://coveralls.io/builds/12765610) Coverage remained the same at 69.301

[GitHub] coveralls commented on issue #3211: [WiP] prevent XSS markup viz

2017-08-09 Thread git
coveralls commented on issue #3211: [WiP] prevent XSS markup viz URL: https://github.com/apache/incubator-superset/pull/3211#issuecomment-321381226 [![Coverage Status](https://coveralls.io/builds/12768100/badge)](https://coveralls.io/builds/12768100) Coverage increased (+0.03%)

[GitHub] vibinsv09 commented on issue #3265: Refresh table definition

2017-08-09 Thread git
vibinsv09 commented on issue #3265: Refresh table definition URL: https://github.com/apache/incubator-superset/issues/3265#issuecomment-321385481 I realized now that simply editing and saving it again refreshes the definition. A refresh button to do it would be more helpful --

[GitHub] saguziel opened a new pull request #3267: Use sane Celery defaults to prevent tasks from being delayed

2017-08-09 Thread git
saguziel opened a new pull request #3267: Use sane Celery defaults to prevent tasks from being delayed URL: https://github.com/apache/incubator-superset/pull/3267 @mistercrunch Using these three settings (of which two are provided in the config to show it's recommended), will make

[GitHub] coveralls commented on issue #3267: Use sane Celery defaults to prevent tasks from being delayed

2017-08-09 Thread git
coveralls commented on issue #3267: Use sane Celery defaults to prevent tasks from being delayed URL: https://github.com/apache/incubator-superset/pull/3267#issuecomment-321395760 [![Coverage Status](https://coveralls.io/builds/12769190/badge)](https://coveralls.io/builds/12769190)

[GitHub] mistercrunch commented on a change in pull request #3267: Use sane Celery defaults to prevent tasks from being delayed

2017-08-09 Thread git
mistercrunch commented on a change in pull request #3267: Use sane Celery defaults to prevent tasks from being delayed URL: https://github.com/apache/incubator-superset/pull/3267#discussion_r132326870 ## File path: superset/cli.py ## @@ -194,7 +194,7 @@ def worker(workers

[GitHub] mistercrunch opened a new pull request #3268: [bugfix] preserve order in groupby

2017-08-09 Thread git
mistercrunch opened a new pull request #3268: [bugfix] preserve order in groupby URL: https://github.com/apache/incubator-superset/pull/3268 Recently in https://github.com/apache/incubator-superset/commit/4c3313b01cb508ced8519a68f6479db423974929 I introduced an issue where the order o

[GitHub] coveralls commented on issue #3268: [bugfix] preserve order in groupby

2017-08-09 Thread git
coveralls commented on issue #3268: [bugfix] preserve order in groupby URL: https://github.com/apache/incubator-superset/pull/3268#issuecomment-321414994 [![Coverage Status](https://coveralls.io/builds/12770813/badge)](https://coveralls.io/builds/12770813) Coverage increased (+0

[GitHub] mistercrunch closed pull request #3266: Pre fill Druid ports

2017-08-09 Thread git
mistercrunch closed pull request #3266: Pre fill Druid ports URL: https://github.com/apache/incubator-superset/pull/3266 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] coveralls commented on issue #3268: [bugfix] preserve order in groupby

2017-08-09 Thread git
coveralls commented on issue #3268: [bugfix] preserve order in groupby URL: https://github.com/apache/incubator-superset/pull/3268#issuecomment-321419201 [![Coverage Status](https://coveralls.io/builds/12771099/badge)](https://coveralls.io/builds/12771099) Coverage increased (+0

[GitHub] mistercrunch commented on issue #3211: [security] prevent XSS markup viz

2017-08-09 Thread git
mistercrunch commented on issue #3211: [security] prevent XSS markup viz URL: https://github.com/apache/incubator-superset/pull/3211#issuecomment-321419265 The only issue left is somewhere around our custom font "Roboto" not working in iframes. Can we helvetica? -

[GitHub] RoganW commented on a change in pull request #3183: [add] Save filters to dashboard

2017-08-09 Thread git
RoganW commented on a change in pull request #3183: [add] Save filters to dashboard URL: https://github.com/apache/incubator-superset/pull/3183#discussion_r132342248 ## File path: superset/models/core.py ## @@ -322,6 +323,18 @@ def table_names(self): @property

[GitHub] mistercrunch closed pull request #3268: [bugfix] preserve order in groupby

2017-08-09 Thread git
mistercrunch closed pull request #3268: [bugfix] preserve order in groupby URL: https://github.com/apache/incubator-superset/pull/3268 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] mistercrunch commented on issue #550: Dashboard Access Control to specific user

2017-08-09 Thread git
mistercrunch commented on issue #550: Dashboard Access Control to specific user URL: https://github.com/apache/incubator-superset/issues/550#issuecomment-321423270 Currently it's data-centric access definition, assuming that we want users to slice/dice to answer their own questions beyond

[GitHub] mistercrunch commented on issue #3034: add `_()` to Exception messages

2017-08-09 Thread git
mistercrunch commented on issue #3034: add `_()` to Exception messages URL: https://github.com/apache/incubator-superset/pull/3034#issuecomment-321423956 LGTM except for the broken build This is an automated message from the

[GitHub] shrutimkrishnan commented on issue #504: Access control on the explore page

2017-08-09 Thread git
shrutimkrishnan commented on issue #504: Access control on the explore page URL: https://github.com/apache/incubator-superset/issues/504#issuecomment-321427988 Tried it out @mistercrunch but not sure if my requirement was the same as described here. I'm looking for user to have restricted

[GitHub] shrutimkrishnan commented on issue #1304: Slice CSV export from dashboard

2017-08-09 Thread git
shrutimkrishnan commented on issue #1304: Slice CSV export from dashboard URL: https://github.com/apache/incubator-superset/issues/1304#issuecomment-321428060 We need the same feature - anybody able to bring csv export option on to dashboard without going into explore view? -

[GitHub] coveralls commented on issue #3267: Use sane Celery defaults to prevent tasks from being delayed

2017-08-09 Thread git
coveralls commented on issue #3267: Use sane Celery defaults to prevent tasks from being delayed URL: https://github.com/apache/incubator-superset/pull/3267#issuecomment-321429055 [![Coverage Status](https://coveralls.io/builds/12771561/badge)](https://coveralls.io/builds/12771561)

[GitHub] shrutimkrishnan opened a new issue #3269: Put filters in an array instead of filters on strings only on Dashboard

2017-08-09 Thread git
shrutimkrishnan opened a new issue #3269: Put filters in an array instead of filters on strings only on Dashboard URL: https://github.com/apache/incubator-superset/issues/3269 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superse

[GitHub] xiaomaolu opened a new issue #3270: Superset worker problem

2017-08-09 Thread git
xiaomaolu opened a new issue #3270: Superset worker problem URL: https://github.com/apache/incubator-superset/issues/3270 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as

[GitHub] coveralls commented on issue #3034: add `_()` to Exception messages

2017-08-09 Thread git
coveralls commented on issue #3034: add `_()` to Exception messages URL: https://github.com/apache/incubator-superset/pull/3034#issuecomment-321444713 [![Coverage Status](https://coveralls.io/builds/12772265/badge)](https://coveralls.io/builds/12772265) Coverage increased (+0.02

[GitHub] coveralls commented on issue #3034: add `_()` to Exception messages

2017-08-09 Thread git
coveralls commented on issue #3034: add `_()` to Exception messages URL: https://github.com/apache/incubator-superset/pull/3034#issuecomment-321444714 [![Coverage Status](https://coveralls.io/builds/12772265/badge)](https://coveralls.io/builds/12772265) Coverage increased (+0.02

[GitHub] coveralls commented on issue #3034: add `_()` to Exception messages

2017-08-09 Thread git
coveralls commented on issue #3034: add `_()` to Exception messages URL: https://github.com/apache/incubator-superset/pull/3034#issuecomment-321444715 [![Coverage Status](https://coveralls.io/builds/12772265/badge)](https://coveralls.io/builds/12772265) Coverage increased (+0.02

[GitHub] mistercrunch commented on issue #3270: Superset worker problem

2017-08-09 Thread git
mistercrunch commented on issue #3270: Superset worker problem URL: https://github.com/apache/incubator-superset/issues/3270#issuecomment-321454827 I think you must be missing the catalog/default db in your SQLALCHEMY_URI, I think it should look something like `presto://myserver:340

[GitHub] mistercrunch commented on issue #3269: Put filters in an array instead of filters on strings only on Dashboard

2017-08-09 Thread git
mistercrunch commented on issue #3269: Put filters in an array instead of filters on strings only on Dashboard URL: https://github.com/apache/incubator-superset/issues/3269#issuecomment-321455138 You can probably write a WHERE clause that would do that can't you?

[GitHub] mistercrunch closed pull request #3267: Use sane Celery defaults to prevent tasks from being delayed

2017-08-09 Thread git
mistercrunch closed pull request #3267: Use sane Celery defaults to prevent tasks from being delayed URL: https://github.com/apache/incubator-superset/pull/3267 This is an automated message from the Apache Git Service. To r

[GitHub] mistercrunch commented on issue #504: Access control on the explore page

2017-08-09 Thread git
mistercrunch commented on issue #504: Access control on the explore page URL: https://github.com/apache/incubator-superset/issues/504#issuecomment-321456472 @shrutimkrishnan I'm guessing if you could export CSV from the dashboard view you wouldn't need explore at all