[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart

jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. And it is not a problem only in Time Series Line Chart, I was able to

[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart

jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. And it is no a problem only in Time Series Line Chart, I was able to

[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart

jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. In my case, we use Snowflake database and I expected it is related

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart

mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379145499 Can you try on `0.24.0` This is an automated message from the

[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart

mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379145499 Can you try on `0.24.0`? This is an automated message from the

[GitHub] mistercrunch commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179658357 ## File path: superset/assets/javascripts/utils/common.js ## @@ -86,3 +86,12 @@ export

[GitHub] mistercrunch commented on issue #4773: Fix brush with annotations

mistercrunch commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379144362 LGTM. Leaving a bit more time if other committers want to take a look

[GitHub] codecov-io commented on issue #4773: Fix brush with annotations

codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4773: Fix brush with annotations

codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging

[GitHub] betodealmeida opened a new pull request #4773: Fix brush with annotations

betodealmeida opened a new pull request #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773 The brush (time filter) currently does not work with annotations:

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] mistercrunch opened a new pull request #4772: [dashboard] open in edit mode when adding a chart

mistercrunch opened a new pull request #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772 This is an automated message from the Apache Git Service. To

[GitHub] GabeLoins commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

GabeLoins commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179639918 ## File path: superset/assets/javascripts/utils/common.js ## @@ -86,3 +86,12 @@ export

[GitHub] mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types' when col has nuls

mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types' when col has nuls URL: https://github.com/apache/incubator-superset/pull/4771 Error "unorderable types: str() < int()" occurs when grouping by a numerical Druid colummn that contains null values. *

[GitHub] syzuhdi opened a new issue #4770: Cannot display Time Series Line Chart

syzuhdi opened a new issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and included

[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries

fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-379117332 I don't think so, will verify. This is an automated

[GitHub] michellethomas opened a new issue #4769: Permissions - Gamma user can't edit

michellethomas opened a new issue #4769: Permissions - Gamma user can't edit URL: https://github.com/apache/incubator-superset/issues/4769 Gamma users can create datasources through the visualize flow in sqllab but then cannot edit those datasources. We should allow users to edit their

[GitHub] codecov-io commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string

codecov-io commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768#issuecomment-379098776 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=h1) Report

[GitHub] mistercrunch commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string

mistercrunch commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768#issuecomment-379096376 @fabianmenges  This is

[GitHub] EvelynTurner opened a new pull request #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string

EvelynTurner opened a new pull request #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768 Before

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-379091611 fyi hitting some issues testing this with prod data, still working on it. should be able to get the chunk files to

[GitHub] williaster commented on a change in pull request #4727: [webpack] setup lazy loading for all visualizations

williaster commented on a change in pull request #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#discussion_r179614390 ## File path: superset/assets/visualizations/main.js ## @@ -51,53 +51,56 @@

[GitHub] hughhhh closed pull request #4643: Added option to add fill to area line charts

hug closed pull request #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] codecov-io commented on issue #4767: Improve controls layout for Table visualization

codecov-io commented on issue #4767: Improve controls layout for Table visualization URL: https://github.com/apache/incubator-superset/pull/4767#issuecomment-379035259 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=h1) Report > Merging

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-379035275 deprioritizing due to work needing to be done on nvd3 This is

[GitHub] codecov-io commented on issue #4766: [explore] set control default for *showminmax = false

codecov-io commented on issue #4766: [explore] set control default for *showminmax = false URL: https://github.com/apache/incubator-superset/pull/4766#issuecomment-379033745 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379033116 I'll wait on @graceguo-supercat's review before merging this

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379032942 @williaster I agree with `flat` but didn't want to drive it myself as it may upset some users since we have to

[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin

williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379029421 ah, that's nice about the `auto` setting. I'd like to get the `flat` in asap so users see staggered for the minimum amount of

[GitHub] mistercrunch opened a new pull request #4767: Improve controls layout for Table visualization

mistercrunch opened a new pull request #4767: Improve controls layout for Table visualization URL: https://github.com/apache/incubator-superset/pull/4767 https://user-images.githubusercontent.com/487433/38383672-f02b9b00-38c1-11e8-9aac-28b2ccb582c1.png;>

[GitHub] mistercrunch opened a new pull request #4766: [explore] set control default for *showminmax = false

mistercrunch opened a new pull request #4766: [explore] set control default for *showminmax = false URL: https://github.com/apache/incubator-superset/pull/4766 Let's make the defaults less crowded on the axes by not showing the min and max values on the axes (bounds)

[GitHub] timifasubaa commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

timifasubaa commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-379007258 Seen. I'll send out a PR to fix this case.

[GitHub] mistercrunch commented on issue #4394: Implement the column config and row config in pivot table

mistercrunch commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-379005432 @michellethomas do you think this conflicts with your goal of deprecating `datatables`?

[GitHub] mistercrunch closed pull request #4673: Add context to templates / respect slice timeout

mistercrunch closed pull request #4673: Add context to templates / respect slice timeout URL: https://github.com/apache/incubator-superset/pull/4673 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

mistercrunch commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-379003741 @timifasubaa

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files (though your hypothesis seems

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files and I can explore pipenv,

[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing

mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378973490 Also I'm not clear on how Pypi operates, but my guess is that it only looks at what's in `setup.py` and

[GitHub] marslhx commented on issue #4151: Mapbox maps not rendering

marslhx commented on issue #4151: Mapbox maps not rendering URL: https://github.com/apache/incubator-superset/issues/4151#issuecomment-378845012 I meet this problem in another occasion. I added my registered API token of Mapbox in superset_config.py. And add path of it to

[GitHub] Stevie337 commented on issue #4394: Implement the column config and row config in pivot table

Stevie337 commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-378843824 Hi All, Has this PR already been pushed?? Ifso in what build would this be?

[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175 @mistercrunch @john-bodley Would (pipenv)[https://docs.pipenv.org/] solve our problems here?

[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175 @mistercrunch @john-bodley Would pipenv[https://docs.pipenv.org/] solve our problems here?

[GitHub] marslhx commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

marslhx commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-378839380 Add which folder to where? How to set the permission. Thanks!

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378831814 @mistercrunch I definitely explored the `pip-compile` route as it would be great to have `requirements.txt`

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4708: Does Superset have an API to expose a Chart's JSON data?

mistercrunch commented on issue #4708: Does Superset have an API to expose a Chart's JSON data? URL: https://github.com/apache/incubator-superset/issues/4708#issuecomment-378828914 Flask App Builder (FAB) offers a CRUD REST API out of the box for all models. Check out: ```