[GitHub] SpyderRivera commented on issue #4740: Add extraction function support for Druid queries

2018-05-02 Thread GitBox
SpyderRivera commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386110982 The filtering works when an extractionFn is added to the dimension spec of the lookup, but then the look up doesn't w

[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries

2018-05-02 Thread GitBox
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/do

[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries

2018-05-02 Thread GitBox
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/do

[GitHub] jasnovak commented on issue #4740: Add extraction function support for Druid queries

2018-05-02 Thread GitBox
jasnovak commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386051860 Hmm, I'm not sure where you are suggesting using DimensionSpec in this PR. Or are you asking that about the code in gener

[GitHub] villebro commented on issue #4920: form_data always returns empty dict

2018-05-02 Thread GitBox
villebro commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386039997 Yeah, a big setback, and a feature we'd really need. I'll look into building the opt-in feature described in #4260 --

[GitHub] guillaumewibaux commented on issue #4920: form_data always returns empty dict

2018-05-02 Thread GitBox
guillaumewibaux commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386038400 Damn... thanks for pointing that out though. Any suggestions/ideas how to mitigate that ? --

[GitHub] codecov-io commented on issue #4921: [bufix] filtered column was removed

2018-05-02 Thread GitBox
codecov-io commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-386036637 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr&el=h1) Report > Merging [#4921](https://codecov.io/g

[GitHub] codecov-io commented on issue #4921: [bufix] filtered column was removed

2018-05-02 Thread GitBox
codecov-io commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-386036637 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr&el=h1) Report > Merging [#4921](https://codecov.io/g

[GitHub] mistercrunch opened a new pull request #4921: [bufix] filtered column was removed

2018-05-02 Thread GitBox
mistercrunch opened a new pull request #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921 https://user-images.githubusercontent.com/487433/39535063-d7d86d22-4de7-11e8-965b-41ae316116d9.png";> if a filter is created on a chart, a

[GitHub] villebro commented on issue #4920: form_data always returns empty dict

2018-05-02 Thread GitBox
villebro commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386006567 I found this, apparently form_data has been deprecated: #4260 This is

[GitHub] grafke commented on issue #4666: Sessions still active on Datasource

2018-05-02 Thread GitBox
grafke commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-385967561 Hi, We're using superset 0.24.0 and the issue is still there. Every time I run a query on the SQL lab, a new connection is made to th

[GitHub] rhunwicks commented on issue #3973: uglifyjs-webpack-plugin@^0.4.6 and uglifyjs-webpack-plugin@^1.1.0 both in use

2018-05-02 Thread GitBox
rhunwicks commented on issue #3973: uglifyjs-webpack-plugin@^0.4.6 and uglifyjs-webpack-plugin@^1.1.0 both in use URL: https://github.com/apache/incubator-superset/issues/3973#issuecomment-385961205 Our attempt to build the JavaScript assets is failing with: ``` ERROR in dashboar

[GitHub] diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04

2018-05-02 Thread GitBox
diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385936086 Here we go: ``` $ dpkg -l openssl* libssl* dpkg-query: no packages found matc

[GitHub] xrmx commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04

2018-05-02 Thread GitBox
xrmx commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385932801 Could you please provide the output of "dpkg -l openssl* libssl*" ?

[GitHub] diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04

2018-05-02 Thread GitBox
diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385932225 I am encountering the same problem. Any solution? ---

[GitHub] guillaumewibaux commented on issue #4920: form_data always returns empty dict

2018-05-02 Thread GitBox
guillaumewibaux commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-385914429 Same issue for me: https://github.com/apache/incubator-superset/issues/1996 ---

[GitHub] claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters

2018-05-02 Thread GitBox
claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385911928 Is there a design document that explains this feature in more detail? --

[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart

2018-05-02 Thread GitBox
peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart URL: https://github.com/apache/incubator-superset/pull/4871#discussion_r185432767 ## File path: superset/viz.py ## @@ -2375,6 +2375,35 @@ def get_data(self, df): return resul

[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart

2018-05-02 Thread GitBox
peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart URL: https://github.com/apache/incubator-superset/pull/4871#discussion_r185432004 ## File path: superset/viz.py ## @@ -2375,6 +2375,35 @@ def get_data(self, df): return resul

[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart

2018-05-02 Thread GitBox
peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart URL: https://github.com/apache/incubator-superset/pull/4871#discussion_r185430056 ## File path: superset/viz.py ## @@ -2375,6 +2375,35 @@ def get_data(self, df): return resul

[GitHub] kuriancheeramelil commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted

2018-05-02 Thread GitBox
kuriancheeramelil commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915#issuecomment-385903678 Thank you @mistercrunch.

[GitHub] guillaumewibaux commented on issue #1996: Custom SQL queries with filters

2018-05-02 Thread GitBox
guillaumewibaux commented on issue #1996: Custom SQL queries with filters URL: https://github.com/apache/incubator-superset/issues/1996#issuecomment-385898140 I tried to access "time_grain_sqla" (or any other key) in _form_data_ dict in Explore but I am afraid that it is empty. I th

[GitHub] villebro opened a new issue #4920: form_data always returns empty dict

2018-05-02 Thread GitBox
villebro opened a new issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included

[GitHub] mistercrunch commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters

2018-05-01 Thread GitBox
mistercrunch commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385869786 It's planned for the next version of the dashboard app to have "scoped filters

[GitHub] mistercrunch commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
mistercrunch commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385869242 I wouldn't recommend running on Windows since Superset isn't tested against it. You will hit problems like this one. Even if you'd fix this issu

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385862029 @darylerwin @mistercrunch sorry it is a typo from my end. The actual error is SIGALRM as mentioned by @mxmzdlv Module 'signal has no at

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385862029 @darylerwin @mistercrunch sorry it is a typo from my end. The actual error is SIGALRM as mentioned by @mxmzdlv Module 'signal has no at

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385862029 @darylerwin @mistercrunch sorry it is a typo from my end. The actual error is SIGALRM as mentioned by @mxmzdlv Module 'signal has n

[GitHub] mistercrunch closed pull request #4917: Add doc entry for BigQuery support

2018-05-01 Thread GitBox
mistercrunch closed pull request #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] mistercrunch closed issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
mistercrunch closed issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] john-bodley commented on a change in pull request #4800: Improve the calendar heatmap

2018-05-01 Thread GitBox
john-bodley commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r185370228 ## File path: superset/migrations/versions/c9495751e314_.py ## @@ -0,0 +1,22 @@ +"""empty message Rev

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385803221 > I'm guessing the load time improvements have to do with the fact that some of the work can be started upfront while

[GitHub] graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page

2018-05-01 Thread GitBox
graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919#issuecomment-385798104 @mistercrunch Alpha and Gamma user can't access their own profile page. is this logic in FAB code base?

[GitHub] graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page

2018-05-01 Thread GitBox
graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919#issuecomment-385798104 @mistercrunch Alpha and Gamma user can't see their profile page. is this logic in FAB code base? Tha

[GitHub] graceguo-supercat opened a new issue #4919: [Profile]Gamma, Alpha user can't see their profile page

2018-05-01 Thread GitBox
graceguo-supercat opened a new issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for py

[GitHub] mistercrunch commented on issue #1413: Added average metric AVG() to default metrics

2018-05-01 Thread GitBox
mistercrunch commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385794518 You have to create post-aggregations for averages on Druid.

[GitHub] graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards

2018-05-01 Thread GitBox
graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r185330381 ## File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx ## @@ -157,2

[GitHub] graceguo-supercat commented on issue #4833: [sqllab] Help sqllab forget query history

2018-05-01 Thread GitBox
graceguo-supercat commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385783066 current auto query refresh component work like this: - in client-side, from all queries in local storage, it find

[GitHub] mistercrunch closed issue #4915: Exploring BQ table throws query error as date is incorrectly formatted

2018-05-01 Thread GitBox
mistercrunch closed issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915 This is an automated message from the Apache Git Service.

[GitHub] mistercrunch closed pull request #4918: Fix typos from linting

2018-05-01 Thread GitBox
mistercrunch closed pull request #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards

2018-05-01 Thread GitBox
codecov-io commented on issue #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=h1) Report > Merging [#4760](https://codecov.io/gh/apache

[GitHub] LanDeQuHuXi commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters

2018-05-01 Thread GitBox
LanDeQuHuXi commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385780560 +1 This is an

[GitHub] mistercrunch closed pull request #4911: Fix for week_start_sunday and week_ending_saturday

2018-05-01 Thread GitBox
mistercrunch closed pull request #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-05-01 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385761026 PING Quick update on the state of the logic. What is really happening is that the frontend ceases to poll for queries

[GitHub] mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics

2018-05-01 Thread GitBox
mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385751870 Hi, I am using latest version of superset (0.24) but average is not activated as a metric when I create a chart/slic

[GitHub] mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics

2018-05-01 Thread GitBox
mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385751870 Hi, I am using latest version of superset (0.24) but average is not activated as a metric

[GitHub] mistercrunch closed pull request #4908: Replace NaN/Infinity with null

2018-05-01 Thread GitBox
mistercrunch closed pull request #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null

2018-05-01 Thread GitBox
betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#discussion_r185292674 ## File path: superset/views/core.py ## @@ -2435,7 +2436,7 @@ def sql_json(self): res

[GitHub] codecov-io commented on issue #4819: Visualization for multiple line charts

2018-05-01 Thread GitBox
codecov-io commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-383682187 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr&el=h1) Report > Merging [#4819](https://codecov.i

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-05-01 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
darylerwin commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385737552 @swamy16 is that a typo in the alarm and perhaps related to this windows signal python issue? https://github.com/Unity-Technologies/ml-agents/i

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-05-01 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] mistercrunch commented on issue #3724: SECRET_KEY encrypts database secrets without warning, possibly breaking web interface if changed

2018-05-01 Thread GitBox
mistercrunch commented on issue #3724: SECRET_KEY encrypts database secrets without warning, possibly breaking web interface if changed URL: https://github.com/apache/incubator-superset/issues/3724#issuecomment-385736855 FYI the easiest way is to use `DB_CONNECTION_MUTATOR` that you can de

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-05-01 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385718217 I'm worried about the way things look here without bundling visualizations together. The sum of all visualization i

[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385719915 We need to fix the fact that `filter_box` is 12mb. I'm thinking for visualizations that use `React`, they shouldn't

[GitHub] johnsks commented on issue #4037: table view pagination

2018-05-01 Thread GitBox
johnsks commented on issue #4037: table view pagination URL: https://github.com/apache/incubator-superset/issues/4037#issuecomment-385718766 Hello all, We are currently using 0.23.0dev, and have quite a few table views in our implementation. The lack of pagination is impacting the

[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385718217 I'm worried about the way things look here without bundling visualizations together. The sum of all visualization i

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385716957 I can give deck.gl a shot if you want tho, I think the d3 bundle is almost over optimizing. That'll be harder to unta

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385716957 I can give deck.gl a shot if you want tho, I think the d3 bundle is almost over optimizing. That'll be harder to unta

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385715788 It's not as trivial as using the same chunk name. The final name consists of chunk name and hash. I'd rather

[GitHub] codecov-io commented on issue #4918: Fix typos from linting

2018-05-01 Thread GitBox
codecov-io commented on issue #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918#issuecomment-385713818 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr&el=h1) Report > Merging [#4918](https://codecov.io/gh/apache/incu

[GitHub] codecov-io commented on issue #4917: Add doc entry for BigQuery support

2018-05-01 Thread GitBox
codecov-io commented on issue #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917#issuecomment-385710264 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr&el=h1) Report > Merging [#4917](https://codecov.io/gh

[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts

2018-05-01 Thread GitBox
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-385708415 Cool, please fix merge conflicts, as this looks like it's ready to be merged. ---

[GitHub] mistercrunch commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted

2018-05-01 Thread GitBox
mistercrunch commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915#issuecomment-385708066 Thanks for reporting this, https://github.com/apache/incubator-superset/pull/4918 addresses th

[GitHub] mistercrunch opened a new pull request #4918: Fix typos from linting

2018-05-01 Thread GitBox
mistercrunch opened a new pull request #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918 Caused by https://github.com/apache/incubator-superset/pull/3847 Fixes https://github.com/apache/incubator-superset/issues/4915 Greped for more of th

[GitHub] mistercrunch commented on a change in pull request #3847: [flake8] Resolving Q??? errors

2018-05-01 Thread GitBox
mistercrunch commented on a change in pull request #3847: [flake8] Resolving Q??? errors URL: https://github.com/apache/incubator-superset/pull/3847#discussion_r185256223 ## File path: superset/db_engine_specs.py ## @@ -1068,21 +1068,21 @@ class ImpalaEngineSpec(BaseEngin

[GitHub] mistercrunch commented on a change in pull request #3847: [flake8] Resolving Q??? errors

2018-05-01 Thread GitBox
mistercrunch commented on a change in pull request #3847: [flake8] Resolving Q??? errors URL: https://github.com/apache/incubator-superset/pull/3847#discussion_r185256095 ## File path: superset/db_engine_specs.py ## @@ -1043,22 +1043,22 @@ class BQEngineSpec(BaseEngineSpe

[GitHub] mistercrunch closed pull request #4913: Fix country_map visualization URL

2018-05-01 Thread GitBox
mistercrunch closed pull request #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] mistercrunch opened a new pull request #4917: Add doc entry for BigQuery support

2018-05-01 Thread GitBox
mistercrunch opened a new pull request #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917 closes https://github.com/apache/incubator-superset/issues/945 This is an automated m

[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385704283 We should use the same webchunk name for all `deckgl`-related charts, same for `nvd3` and same all the ones that on

[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385704283 We should use the same webchunk name for all `deckgl`-related charts, same for `nvd3` and same all the ones that on

[GitHub] mistercrunch commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)

2018-05-01 Thread GitBox
mistercrunch commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916#issuecomment-385699143 I think you're misinterpreting the logs. Superset does not require writing to target d

[GitHub] xrmx commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)

2018-05-01 Thread GitBox
xrmx commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916#issuecomment-385671694 You may want to raise debugging level to see more interesting things. Superset works perfectly

[GitHub] malsmith opened a new issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)

2018-05-01 Thread GitBox
malsmith opened a new issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superse

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385653782 @mxmzdlv thanks for the help. I shall try installing superset in virtualbox. also is it possible to share the dashboards I create on superset w

[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
mxmzdlv commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385631372 @swamy16 seems to be an issue with calling signal(signal.SIGALRM) — SIGALRM is not available on Windows. https://github.com/apache/incubator-superse

[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
mxmzdlv commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385631372 @swamy16 seems to be an issue with calling signal(signal.SIGALRM) — SIGALRM is not available on Windows. https://github.com/apache/incubator-superse

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385619874 @tswast @darylerwin @mistercrunch @mxmzdlv @Bamieh Thanks to you guys (your guidance) I was finally able to connect my superset to bigquery in wi

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

2018-05-01 Thread GitBox
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385619874 @tswast @darylerwin @mistercrunch @mxmzdlv Thanks to you guys (your guidance) I was finally able to connect my superset to bigquery in windows.

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-05-01 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385615006 I got chunk names to update (see exact webpack input / output below) and wanted to post some numbers from local dashb

[GitHub] williaster commented on issue #4913: Fix country_map visualization URL

2018-05-01 Thread GitBox
williaster commented on issue #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913#issuecomment-385612991 lgtm This is an automated message from the Apache Git Service. To respo

[GitHub] kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query error as date is incorrectly formatted

2018-04-30 Thread GitBox
kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the supers

[GitHub] mistercrunch closed pull request #4910: Use React.PureComponent everywhere

2018-04-30 Thread GitBox
mistercrunch closed pull request #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] mistercrunch commented on issue #4343: fixing Issue #4335 - Not quoting column name when doing a time series

2018-04-30 Thread GitBox
mistercrunch commented on issue #4343: fixing Issue #4335 - Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/pull/4343#issuecomment-385610298 @kstan79 I think this is fixed on master, can you confirm? --

[GitHub] mistercrunch opened a new pull request #4914: [WiP] make MetricsControl the standard across visualizations

2018-04-30 Thread GitBox
mistercrunch opened a new pull request #4914: [WiP] make MetricsControl the standard across visualizations URL: https://github.com/apache/incubator-superset/pull/4914 This spreads MetricsControl across visualizations. This is

[GitHub] codecov-io commented on issue #4913: Fix country_map visualization URL

2018-04-30 Thread GitBox
codecov-io commented on issue #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913#issuecomment-385609581 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr&el=h1) Report > Merging [#4913](https://codecov.io/gh/

[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere

2018-04-30 Thread GitBox
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of r

[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere

2018-04-30 Thread GitBox
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of r

[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere

2018-04-30 Thread GitBox
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of r

[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere

2018-04-30 Thread GitBox
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of r

[GitHub] mistercrunch opened a new pull request #4913: Fix country_map visualization URL

2018-04-30 Thread GitBox
mistercrunch opened a new pull request #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913 When moving the visualizations/ folder to src/ I missed this reference. This is an aut

[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries

2018-04-30 Thread GitBox
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385596164 We currently don't use extraction functions either. This may have already been answered, but I'm curious why

[GitHub] john-bodley commented on issue #4740: Add extraction function support for Druid queries

2018-04-30 Thread GitBox
john-bodley commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385579265 @mistercrunch I don't believe we use extraction functions in any of the Druid clusters connected to Superset (per a qu

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-04-30 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-04-30 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries

2018-04-30 Thread GitBox
fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385575931 Ack, will do. This is an automated message from the

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-04-30 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-04-30 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

2018-04-30 Thread GitBox
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr&el=h1) Report > Merging [#4911](http

  1   2   3   4   5   6   7   8   9   10   >