[GitHub] graceguo-supercat commented on issue #3771: DECKGL integration - Phase 1

2017-11-16 Thread GitBox
graceguo-supercat commented on issue #3771: DECKGL integration - Phase 1 URL: https://github.com/apache/incubator-superset/pull/3771#issuecomment-344850625 LGTM This is an automated message from the Apache Git Service. To res

[GitHub] amoussoubaruch closed issue #3874: Is possible to use one dashborad with multiples data sources

2017-11-16 Thread GitBox
amoussoubaruch closed issue #3874: Is possible to use one dashborad with multiples data sources URL: https://github.com/apache/incubator-superset/issues/3874 This is an automated message from the Apache Git Service. To resp

[GitHub] amoussoubaruch commented on issue #3874: Is possible to use one dashborad with multiples data sources

2017-11-16 Thread GitBox
amoussoubaruch commented on issue #3874: Is possible to use one dashborad with multiples data sources URL: https://github.com/apache/incubator-superset/issues/3874#issuecomment-344856539 Thanks @mistercrunch It is a good way to do it. I will create for each datasource one grou

[GitHub] dmigo commented on issue #3875: [SqlLab] Filter out unavailable databases

2017-11-16 Thread GitBox
dmigo commented on issue #3875: [SqlLab] Filter out unavailable databases URL: https://github.com/apache/incubator-superset/pull/3875#issuecomment-344870426 @mistercrunch glad to help. It's just I wasn't 100% sure about if it should be `database_access` or `datasource_access `. --

[GitHub] luciuschina commented on issue #3878: How to rename the __timestamp in the table ?

2017-11-16 Thread GitBox
luciuschina commented on issue #3878: How to rename the __timestamp in the table ? URL: https://github.com/apache/incubator-superset/issues/3878#issuecomment-344871025 @mistercrunch Thanks! This is an automated message from

[GitHub] luciuschina closed issue #3878: How to rename the __timestamp in the table ?

2017-11-16 Thread GitBox
luciuschina closed issue #3878: How to rename the __timestamp in the table ? URL: https://github.com/apache/incubator-superset/issues/3878 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] vivekna1 opened a new issue #3883: Not able to execute a post request to Superset

2017-11-16 Thread GitBox
vivekna1 opened a new issue #3883: Not able to execute a post request to Superset URL: https://github.com/apache/incubator-superset/issues/3883 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces an

[GitHub] vivekna1 commented on issue #3883: Not able to execute a post request to Superset

2017-11-16 Thread GitBox
vivekna1 commented on issue #3883: Not able to execute a post request to Superset URL: https://github.com/apache/incubator-superset/issues/3883#issuecomment-344882330 --- The error log in Server side.--- 2017-11-16 15:37:58,379:ERROR:flask_appbuilder.models.sqla.interface:Add record er

[GitHub] luciuschina opened a new issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window

2017-11-16 Thread GitBox
luciuschina opened a new issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window URL: https://github.com/apache/incubator-superset/issues/3884 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs

[GitHub] amoussoubaruch commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
amoussoubaruch commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344899795 @dqzgzjhzjbhzl what did you mean by drop-down box? Which dataviz type did you want to use?

[GitHub] frankfarrell opened a new pull request #3885: 3829 Queries using table entity to filter on table_name and database id

2017-11-16 Thread GitBox
frankfarrell opened a new pull request #3885: 3829 Queries using table entity to filter on table_name and database id URL: https://github.com/apache/incubator-superset/pull/3885 This is an automated message from the Apache G

[GitHub] vivekna1 commented on issue #3883: Not able to execute a post request to Superset

2017-11-16 Thread GitBox
vivekna1 commented on issue #3883: Not able to execute a post request to Superset URL: https://github.com/apache/incubator-superset/issues/3883#issuecomment-344882330 --- The error log in Server side.--- 2017-11-16 15:37:58,379:ERROR:flask_appbuilder.models.sqla.interface:Add record er

[GitHub] dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344944365 @amoussoubaruch i want to use Word Cloud. ![word cloud](https://github.com/dqzgzjhzjbhzl/test/blob/master/word%20cloud.png

[GitHub] dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344944365 @amoussoubaruch i want to use Word Cloud. ![word cloud](https://raw.githubusercontent.com/dqzgzjhzjbhzl/test/master/word%2

[GitHub] frankfarrell commented on issue #3829: Cannot create table with same name from a different datasource

2017-11-16 Thread GitBox
frankfarrell commented on issue #3829: Cannot create table with same name from a different datasource URL: https://github.com/apache/incubator-superset/issues/3829#issuecomment-344947528 Root cause here is that the alembic migrations scripts first creates a unique constraint on table name

[GitHub] fabianmenges commented on issue #3879: Allow users to specify label->color mapping

2017-11-16 Thread GitBox
fabianmenges commented on issue #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879#issuecomment-344949382 This is out of scope of this change, but I feel like we should have a UI to do this and not just manually writing json into

[GitHub] fabianmenges commented on issue #3876: Fix slug function

2017-11-16 Thread GitBox
fabianmenges commented on issue #3876: Fix slug function URL: https://github.com/apache/incubator-superset/pull/3876#issuecomment-344949950 What about international 'slugs'? This is an automated message from the Apache Git Se

[GitHub] amoussoubaruch commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
amoussoubaruch commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344963520 @dqzgzjhzjbhzl Change your metric and test This is an autom

[GitHub] dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344966326 @amoussoubaruch in the red box , i select 5, then the number of name in the Word Cloud should be 5. is it right?

[GitHub] amoussoubaruch commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
amoussoubaruch commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-344974501 I thinks that series limit parameter is like select topN. So i select only 5 row in your dataset

[GitHub] john-bodley commented on issue #3881: [linting] Cleaning up linting documentation

2017-11-16 Thread GitBox
john-bodley commented on issue #3881: [linting] Cleaning up linting documentation URL: https://github.com/apache/incubator-superset/pull/3881#issuecomment-344982717 @xrmx I see you point. Couldn't one also argue that from a testing perspective instead of having flake8, pylint, etc. define

[GitHub] nikitathampi opened a new issue #3886: Long queries run successfully but aren't displaying any results

2017-11-16 Thread GitBox
nikitathampi opened a new issue #3886: Long queries run successfully but aren't displaying any results URL: https://github.com/apache/incubator-superset/issues/3886 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for

[GitHub] mistercrunch closed pull request #3880: [table] show 'Time' column header instead of '__timestamp'

2017-11-16 Thread GitBox
mistercrunch closed pull request #3880: [table] show 'Time' column header instead of '__timestamp' URL: https://github.com/apache/incubator-superset/pull/3880 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] mistercrunch commented on issue #3879: Allow users to specify label->color mapping

2017-11-16 Thread GitBox
mistercrunch commented on issue #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879#issuecomment-344999532 Totally agree about the docs, I think about this every time I add an FAQ entry. It's just always out-of-scope for the parti

[GitHub] mistercrunch commented on issue #3879: Allow users to specify label->color mapping

2017-11-16 Thread GitBox
mistercrunch commented on issue #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879#issuecomment-345001998 Also agree about having this in the UI and that's true of most of the things in "Metadata JSON". I think it's a good

[GitHub] mistercrunch commented on issue #3876: Fix slug function

2017-11-16 Thread GitBox
mistercrunch commented on issue #3876: Fix slug function URL: https://github.com/apache/incubator-superset/pull/3876#issuecomment-345002625 Yeah I researched this a bit and refrained from adding a dependency that does this.

[GitHub] mistercrunch closed pull request #3876: Fix slug function

2017-11-16 Thread GitBox
mistercrunch closed pull request #3876: Fix slug function URL: https://github.com/apache/incubator-superset/pull/3876 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reque

[GitHub] mistercrunch closed issue #3803: [Dashboard][Slug] Spaces and hyphens are being ignored.

2017-11-16 Thread GitBox
mistercrunch closed issue #3803: [Dashboard][Slug] Spaces and hyphens are being ignored. URL: https://github.com/apache/incubator-superset/issues/3803 This is an automated message from the Apache Git Service. To respond to t

[GitHub] mistercrunch commented on issue #3851: A better looking favicon

2017-11-16 Thread GitBox
mistercrunch commented on issue #3851: A better looking favicon URL: https://github.com/apache/incubator-superset/pull/3851#issuecomment-345010539 Well with retina now 32 is way too small. It weights 8kb as is and gets cached. Tested it works both on FF and GC

[GitHub] mistercrunch closed pull request #3851: A better looking favicon

2017-11-16 Thread GitBox
mistercrunch closed pull request #3851: A better looking favicon URL: https://github.com/apache/incubator-superset/pull/3851 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] mistercrunch opened a new pull request #3887: Fixing the build's linting errors

2017-11-16 Thread GitBox
mistercrunch opened a new pull request #3887: Fixing the build's linting errors URL: https://github.com/apache/incubator-superset/pull/3887 @john-bodley master has new linting rules, PRs got merged with lint that was ok at branching but not ok in masert anymore We should pr

[GitHub] mistercrunch commented on issue #3879: Allow users to specify label->color mapping

2017-11-16 Thread GitBox
mistercrunch commented on issue #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879#issuecomment-345016477 Waiting for https://github.com/apache/incubator-superset/pull/3887 to rebase against -

[GitHub] mistercrunch commented on issue #3852: fix input height to match with react-select

2017-11-16 Thread GitBox
mistercrunch commented on issue #3852: fix input height to match with react-select URL: https://github.com/apache/incubator-superset/pull/3852#issuecomment-345016872 LGTM This is an automated message from the Apache Git Serv

[GitHub] hughhhh commented on issue #3887: Fixing the build's linting errors

2017-11-16 Thread GitBox
hug commented on issue #3887: Fixing the build's linting errors URL: https://github.com/apache/incubator-superset/pull/3887#issuecomment-345033084 ? This is an automated message from the Apache Git Service. To respond to

[GitHub] mistercrunch closed pull request #3887: Fixing the build's linting errors

2017-11-16 Thread GitBox
mistercrunch closed pull request #3887: Fixing the build's linting errors URL: https://github.com/apache/incubator-superset/pull/3887 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] graceguo-supercat closed issue #3830: Fix react-select's height

2017-11-16 Thread GitBox
graceguo-supercat closed issue #3830: Fix react-select's height URL: https://github.com/apache/incubator-superset/issues/3830 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] graceguo-supercat closed pull request #3852: fix input height to match with react-select

2017-11-16 Thread GitBox
graceguo-supercat closed pull request #3852: fix input height to match with react-select URL: https://github.com/apache/incubator-superset/pull/3852 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] michellethomas opened a new issue #3888: Filter box slices with instantFiltering turned off don't run

2017-11-16 Thread GitBox
michellethomas opened a new issue #3888: Filter box slices with instantFiltering turned off don't run URL: https://github.com/apache/incubator-superset/issues/3888 Working through an issue where filters with instantFiltering turned off (filters that have the apply button) don't filter char

[GitHub] john-bodley commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id

2017-11-16 Thread GitBox
john-bodley commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id URL: https://github.com/apache/incubator-superset/pull/3885#issuecomment-345082029 @frankfarrel would you mind adding a description to help provide more context? Also there are so

[GitHub] john-bodley commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id

2017-11-16 Thread GitBox
john-bodley commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id URL: https://github.com/apache/incubator-superset/pull/3885#issuecomment-345082029 @frankfarrell would you mind adding a description to help provide more context? Also there are s

[GitHub] jcollado opened a new issue #3889: Unable to use custom druid dimensions

2017-11-16 Thread GitBox
jcollado opened a new issue #3889: Unable to use custom druid dimensions URL: https://github.com/apache/incubator-superset/issues/3889 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and included

[GitHub] graceguo-supercat opened a new pull request #3890: [dashboard bug]Instant control should take effect instantly

2017-11-16 Thread GitBox
graceguo-supercat opened a new pull request #3890: [dashboard bug]Instant control should take effect instantly URL: https://github.com/apache/incubator-superset/pull/3890 in explore view, controls like color csheme, legend, rich tooltip, etc., change these controls should see effect instan

[GitHub] fabianmenges opened a new pull request #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format

2017-11-16 Thread GitBox
fabianmenges opened a new pull request #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format URL: https://github.com/apache/incubator-superset/pull/3891 Between this `or` https://github.com/apache/incubator-superset/blob/fa35d7d2f47d2f5b664d0433ea1be677924767e6/superset/co

[GitHub] fabianmenges opened a new pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions)

2017-11-16 Thread GitBox
fabianmenges opened a new pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions) URL: https://github.com/apache/incubator-superset/pull/3892 When you create a group-by query using the UI it will create a subquery which will contain the time filter of the

[GitHub] williaster commented on issue #3879: Allow users to specify label->color mapping

2017-11-16 Thread GitBox
williaster commented on issue #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879#issuecomment-345128365 @mistercrunch @fabianmenges we have been discussing adding global `time` + global `color` controls to dashboards in our dashbo

[GitHub] michellethomas opened a new pull request #3893: Only refreshing non instant filters on apply

2017-11-16 Thread GitBox
michellethomas opened a new pull request #3893: Only refreshing non instant filters on apply URL: https://github.com/apache/incubator-superset/pull/3893 If instant filter is turned off for filter_box the filters get refreshed in the reducer on changeFilter not clickApply. clickApply should

[GitHub] michellethomas commented on issue #3893: Only refreshing non instant filters on apply

2017-11-16 Thread GitBox
michellethomas commented on issue #3893: Only refreshing non instant filters on apply URL: https://github.com/apache/incubator-superset/pull/3893#issuecomment-345133366 @graceguo-supercat @mistercrunch This is an automated

[GitHub] john-bodley opened a new issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn

2017-11-16 Thread GitBox
john-bodley opened a new issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn URL: https://github.com/apache/incubator-superset/issues/3894 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs f

[GitHub] john-bodley opened a new pull request #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-16 Thread GitBox
john-bodley opened a new pull request #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895 This PR fixes issue https://github.com/apache/incubator-superset/issues/3894. It seems that using multi-processing for fe

[GitHub] john-bodley opened a new pull request #3896: [druid] Fix datasource column enumeration

2017-11-16 Thread GitBox
john-bodley opened a new pull request #3896: [druid] Fix datasource column enumeration URL: https://github.com/apache/incubator-superset/pull/3896 Whilst debugging https://github.com/apache/incubator-superset/issues/3894 I noticed that the query to fetch Druid columns (line #172) would fai

[GitHub] john-bodley opened a new pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-16 Thread GitBox
john-bodley opened a new pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897 Whilst debugging https://github.com/apache/incubator-superset/issues/3894 I noticed that the calling the PyDruid clien

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-16 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345141488 Multithreaded execution was introduced because refreshing a cluster with many datasources took... a long time. Metad

[GitHub] john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-16 Thread GitBox
john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345141793 Thanks @Mogball for the explanation. Are you opposed to using multi-threading rather than multi-processing? Also

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-16 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345142406 Looks okay to me. I'm pretty sure it should be thread-safe. `refresh_async` was the name of the function when

[GitHub] masterlittle opened a new issue #3898: How to use a count metric in Superset?

2017-11-16 Thread GitBox
masterlittle opened a new issue #3898: How to use a count metric in Superset? URL: https://github.com/apache/incubator-superset/issues/3898 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and inc

[GitHub] Mogball commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-16 Thread GitBox
Mogball commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#issuecomment-345145836 The result of this query is used to determine when to look for metadata. I don't think the method should

[GitHub] john-bodley opened a new pull request #3899: [druid] Renaming refresh_async method

2017-11-16 Thread GitBox
john-bodley opened a new pull request #3899: [druid] Renaming refresh_async method URL: https://github.com/apache/incubator-superset/pull/3899 Whilst debugging https://github.com/apache/incubator-superset/issues/3894 I noticed that the method named `refresh_async` is somewhat of a misnomer

[GitHub] dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid

2017-11-16 Thread GitBox
dqzgzjhzjbhzl commented on issue #3882: word cloud series limit is in invalid URL: https://github.com/apache/incubator-superset/issues/3882#issuecomment-345149316 @mistercrunch so this is a bug This is an automated message f

[GitHub] mistercrunch commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-16 Thread GitBox
mistercrunch commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#issuecomment-345158096 Also think we should fall back on current date time. I think that used to be the default before peop

[GitHub] mistercrunch closed pull request #3896: [druid] Fix Druid datasource column enumeration

2017-11-16 Thread GitBox
mistercrunch closed pull request #3896: [druid] Fix Druid datasource column enumeration URL: https://github.com/apache/incubator-superset/pull/3896 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] vnnw commented on issue #3898: How to use a count metric in Superset?

2017-11-16 Thread GitBox
vnnw commented on issue #3898: How to use a count metric in Superset? URL: https://github.com/apache/incubator-superset/issues/3898#issuecomment-345169901 I think you have to add the metric you want by manually writing a valid sql expression. --

[GitHub] masterlittle commented on issue #3898: How to use a count metric in Superset?

2017-11-16 Thread GitBox
masterlittle commented on issue #3898: How to use a count metric in Superset? URL: https://github.com/apache/incubator-superset/issues/3898#issuecomment-345171456 Yeah figured that out. But do I have do that for every table. Is there some way to add a metric as a global metric, available f

[GitHub] xrmx commented on issue #3881: [linting] Cleaning up linting documentation

2017-11-17 Thread GitBox
xrmx commented on issue #3881: [linting] Cleaning up linting documentation URL: https://github.com/apache/incubator-superset/pull/3881#issuecomment-345180026 I suspect not many people run tox on their machine, but just rely on CI. Either way it's good for me. -

[GitHub] xrmx commented on issue #3898: How to use a count metric in Superset?

2017-11-17 Thread GitBox
xrmx commented on issue #3898: How to use a count metric in Superset? URL: https://github.com/apache/incubator-superset/issues/3898#issuecomment-345180401 Nope, you do it manually or you script it. This is an automated messag

[GitHub] xrmx commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn URL: https://github.com/apache/incubator-superset/issues/3894#issuecomment-345180657 Could you reproduce without a gevent worker?

[GitHub] gdeepali commented on issue #1996: Custom SQL queries with filters

2017-11-17 Thread GitBox
gdeepali commented on issue #1996: Custom SQL queries with filters URL: https://github.com/apache/incubator-superset/issues/1996#issuecomment-345181747 Is it possible to get current logged in user using jinja templates? For example, I want to do something like SELECT * FROM tbl

[GitHub] alanmcruickshank commented on issue #3821: Group the dashboards into Folders when there are too many to view.

2017-11-17 Thread GitBox
alanmcruickshank commented on issue #3821: Group the dashboards into Folders when there are too many to view. URL: https://github.com/apache/incubator-superset/issues/3821#issuecomment-345227716 @graceguo-supercat I love the idea of tagging, rather than tabs or folders. That would

[GitHub] alanmcruickshank commented on issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window

2017-11-17 Thread GitBox
alanmcruickshank commented on issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window URL: https://github.com/apache/incubator-superset/issues/3884#issuecomment-345229061 @luciuschina - I can have a crack at this one.

[GitHub] alanmcruickshank opened a new pull request #3900: Add datasource to the SliceAddView modal (#3884)

2017-11-17 Thread GitBox
alanmcruickshank opened a new pull request #3900: Add datasource to the SliceAddView modal (#3884) URL: https://github.com/apache/incubator-superset/pull/3900 Fix for issue #3884 adding datasource to the "Add Slice" modal on the dashboard view.

[GitHub] john-bodley commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gevent with Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gevent with Gunicorn URL: https://github.com/apache/incubator-superset/issues/3894#issuecomment-345332631 @xrmx it seems like this is actually a Gevent issue as opposed to Gunicorn. I'm update

[GitHub] john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345333095 @Mogball per @xrmx's comment in the issue this may actually be a Gevent issue. I'm not certain whether we want t

[GitHub] xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345359353 If you are just waiting on druid threads instead of processes should be fine. To avoid the possible creation of ton of

[GitHub] xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345359353 If you are just waiting on druid IO threads instead of processes should be fine. To avoid the possible creation of ton

[GitHub] graceguo-supercat commented on issue #3893: Only refreshing non instant filters on apply

2017-11-17 Thread GitBox
graceguo-supercat commented on issue #3893: Only refreshing non instant filters on apply URL: https://github.com/apache/incubator-superset/pull/3893#issuecomment-345362315 LGTM This is an automated message from the Apache Gi

[GitHub] graceguo-supercat closed pull request #3893: Only refreshing non instant filters on apply

2017-11-17 Thread GitBox
graceguo-supercat closed pull request #3893: Only refreshing non instant filters on apply URL: https://github.com/apache/incubator-superset/pull/3893 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch closed pull request #3879: Allow users to specify label->color mapping

2017-11-17 Thread GitBox
mistercrunch closed pull request #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] michellethomas commented on issue #3890: [dashboard bug]Instant control should take effect instantly

2017-11-17 Thread GitBox
michellethomas commented on issue #3890: [dashboard bug]Instant control should take effect instantly URL: https://github.com/apache/incubator-superset/pull/3890#issuecomment-345400997 lgtm This is an automated message from t

[GitHub] graceguo-supercat closed pull request #3890: [dashboard bug]Instant control should take effect instantly

2017-11-17 Thread GitBox
graceguo-supercat closed pull request #3890: [dashboard bug]Instant control should take effect instantly URL: https://github.com/apache/incubator-superset/pull/3890 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] john-bodley commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
john-bodley commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#issuecomment-345403832 @Mogball I updated the logic to revert to the current time. @mistercrunch I went through the code to

[GitHub] john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345404884 @mistercrunch @Mogball @xrmx I'm not overly familiar with this portion of the code base, and the interactions wi

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345406215 The speed up is more than just 4x (or whatever the number of available threads). Most of the time is spent waiting f

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345406215 The speed up is more than just 4x (or whatever the number of available threads). Most of the time is spent waiting f

[GitHub] Mogball commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
Mogball commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#discussion_r151822485 ## File path: superset/connectors/druid/models.py ## @@ -563,11 +563,1

[GitHub] john-bodley commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
john-bodley commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#discussion_r151827678 ## File path: superset/connectors/druid/models.py ## @@ -563,11 +5

[GitHub] liuzn4ever commented on issue #3656: Export Dashboard doesn't work

2017-11-17 Thread GitBox
liuzn4ever commented on issue #3656: Export Dashboard doesn't work URL: https://github.com/apache/incubator-superset/issues/3656#issuecomment-345416549 A page is intercepted by the browser ,you can use the Edge of win10?then you can download the dashboard file,and its suffix name is .pickl

[GitHub] mistercrunch closed pull request #3900: Add datasource to the SliceAddView modal (#3884)

2017-11-17 Thread GitBox
mistercrunch closed pull request #3900: Add datasource to the SliceAddView modal (#3884) URL: https://github.com/apache/incubator-superset/pull/3900 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch closed pull request #3899: [druid] Renaming refresh_async method

2017-11-17 Thread GitBox
mistercrunch closed pull request #3899: [druid] Renaming refresh_async method URL: https://github.com/apache/incubator-superset/pull/3899 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mistercrunch commented on a change in pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions)

2017-11-17 Thread GitBox
mistercrunch commented on a change in pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions) URL: https://github.com/apache/incubator-superset/pull/3892#discussion_r151828077 ## File path: superset/connectors/sqla/models.py ## @@ -529,1

[GitHub] mistercrunch closed pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
mistercrunch closed pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sa

[GitHub] mistercrunch commented on issue #1996: Custom SQL queries with filters

2017-11-17 Thread GitBox
mistercrunch commented on issue #1996: Custom SQL queries with filters URL: https://github.com/apache/incubator-superset/issues/1996#issuecomment-345417447 more like: ``` SELECT * FROM tbl WHERE uername = '{{ current_username() }}' ``` ---

[GitHub] mistercrunch commented on issue #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format

2017-11-17 Thread GitBox
mistercrunch commented on issue #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format URL: https://github.com/apache/incubator-superset/pull/3891#issuecomment-345417893 Travis never fired for this one, maybe pushing a new commit on top will trigger it? -

[GitHub] mistercrunch commented on issue #3861: overlap of Legends with the ToolTip

2017-11-17 Thread GitBox
mistercrunch commented on issue #3861: overlap of Legends with the ToolTip URL: https://github.com/apache/incubator-superset/pull/3861#issuecomment-345417995 Sorry I meant of snapshot of what the visualization looks like not the code. --

[GitHub] mistercrunch commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
mistercrunch commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345418062 Heads up that there are caveats with thread-safety around SQLAlchemy --

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345418884 `latest_metadata` doesn't make any calls to SQLAlchemy ? --

[GitHub] john-bodley commented on issue #3583: [3541] Augmenting datasources uniqueness constraints

2017-11-17 Thread GitBox
john-bodley commented on issue #3583: [3541] Augmenting datasources uniqueness constraints URL: https://github.com/apache/incubator-superset/pull/3583#issuecomment-345424552 @mistercrunch I've resolve all the merge conflicts. ---

[GitHub] frankfarrell commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id

2017-11-18 Thread GitBox
frankfarrell commented on issue #3885: 3829 Queries using table entity to filter on table_name and database id URL: https://github.com/apache/incubator-superset/pull/3885#issuecomment-345433062 @john-bodley Apologies, both updated now.

[GitHub] bolkedebruin commented on issue #1929: Error with postgres columns of type "TIMESTAMP WITH TIME ZONE"

2017-11-18 Thread GitBox
bolkedebruin commented on issue #1929: Error with postgres columns of type "TIMESTAMP WITH TIME ZONE" URL: https://github.com/apache/incubator-superset/issues/1929#issuecomment-345475554 This likely is a bug in Pandas. When using a Postgres field with time zone a DateTimeIndex is created

[GitHub] liuzn4ever opened a new issue #3901: go List Datasource Access Request throw key error

2017-11-18 Thread GitBox
liuzn4ever opened a new issue #3901: go List Datasource Access Request throw key error URL: https://github.com/apache/incubator-superset/issues/3901 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktrac

[GitHub] mistercrunch commented on issue #1929: Error with postgres columns of type "TIMESTAMP WITH TIME ZONE"

2017-11-18 Thread GitBox
mistercrunch commented on issue #1929: Error with postgres columns of type "TIMESTAMP WITH TIME ZONE" URL: https://github.com/apache/incubator-superset/issues/1929#issuecomment-345493719 There's probably a way to convert the column in the dataframe on our side to work around the bug. I s

[GitHub] mistercrunch closed pull request #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-18 Thread GitBox
mistercrunch closed pull request #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

  1   2   3   4   5   6   7   8   9   10   >