Re: Token creation is not thread safe

2018-04-08 Thread Francesco Chicchiriccò
On 09/04/2018 08:46, Isuranga Perera wrote: Hi Francesco, I will take a scenario. Suppose a scenario where thread A & thread B try to login user admin. 1. thread A checks if a token exist for the user admin (suppose currently there is no token associated with the admin) 2. Then thread A

Re: Token creation is not thread safe

2018-04-08 Thread Isuranga Perera
Hi Francesco, I will take a scenario. Suppose a scenario where thread A & thread B try to login user admin. 1. thread A checks if a token exist for the user admin (suppose currently there is no token associated with the admin) 2. Then thread A execute following logic[1] to create and sav

[jira] [Commented] (SYNCOPE-1296) Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SYNCOPE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430136#comment-16430136 ] ASF GitHub Bot commented on SYNCOPE-1296: - Github user ilgrosso commented on the

[jira] [Resolved] (SYNCOPE-1296) Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread JIRA
[ https://issues.apache.org/jira/browse/SYNCOPE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1296. - Resolution: Fixed > Eclipse Plugin OSGI Dependency Issue > -

[jira] [Assigned] (SYNCOPE-1296) Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread JIRA
[ https://issues.apache.org/jira/browse/SYNCOPE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò reassigned SYNCOPE-1296: --- Assignee: Francesco Chicchiriccò > Eclipse Plugin OSGI Dependency I

[GitHub] syncope issue #69: SYNCOPE-1296 Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread ilgrosso
Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/69 Thanks @IsurangaPerera I have merged this PR Did you already send your ICLA? For your future contributions, please always include the referenced issue in proper case, e.g. `SYNCOPE-1296`

[jira] [Commented] (SYNCOPE-1296) Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SYNCOPE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430134#comment-16430134 ] ASF GitHub Bot commented on SYNCOPE-1296: - Github user asfgit closed the pull re

[jira] [Commented] (SYNCOPE-1296) Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SYNCOPE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430133#comment-16430133 ] ASF subversion and git services commented on SYNCOPE-1296: -- Com

[GitHub] syncope pull request #69: SYNCOPE-1296 Eclipse Plugin OSGI Dependency Issue

2018-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/syncope/pull/69 ---

Re: Token creation is not thread safe

2018-04-08 Thread Francesco Chicchiriccò
On 09/04/2018 07:07, Isuranga Perera wrote: Hi All, Token create method in AccessTokenDataBinderImpl[1] is not thread safe. Could you please explain why you're affirming this? This could result in several problems including * Exist 2 different access token for a particular user at a given

Token creation is not thread safe

2018-04-08 Thread Isuranga Perera
Hi All, Token create method in AccessTokenDataBinderImpl[1] is not thread safe. This could result in several problems including - Exist 2 different access token for a particular user at a given time which may result in an exception thrown by method call[2] since it expects a single token