[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera closed the pull request at: https://github.com/apache/syncope/pull/70 ---

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 Yes, that's why we have to see it from a different perspective. The initial state doesn't change the logic of replaceExisting == true But it partially affects replaceExistin

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 That way replace won't work since it saves first (2 tokens exist.violate UNIQUE constraint) and deletes next. That way it will only delete the existing one which results in no token at all. ---

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 Yes, What if we revert it to the initial state? ---

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 A validation error will be raised in the worst case(As I see the thread safe problem won't just affect the login as we discussed Saml as well. So Unique constraint will only prevent

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso As I understand in SAML SP logic always replaced. So even when we logged, as usual, the access token may changed by SAML SP. So I can understand the importance of what

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso Can I know the business rule associated with the access token. Can one user has more than one access token in an any given scenario? ---

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso without enforcing the UNIQUE constraint on the owner as we discussed in the mail I can't see a valid reason for merge these changes ---

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181101464 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181099396 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181094994 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181091428 --- Diff: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java --- @@ -34,6 +34,8

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181090557 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181089295 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java --- @@ -44,7 +44,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181088841 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

GitHub user IsurangaPerera opened a pull request: https://github.com/apache/syncope/pull/70 [SYNCOPE-1301] fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/IsurangaPerera/syncope SYNCOPE-1301 Alternatively you can review

[GitHub] syncope pull request #69: SYNCOPE-1296 Eclipse Plugin OSGI Dependency Issue

GitHub user IsurangaPerera opened a pull request: https://github.com/apache/syncope/pull/69 SYNCOPE-1296 Eclipse Plugin OSGI Dependency Issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/IsurangaPerera/syncope SYNCOPE-1296