Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/85
@AlexTsvetkov I have reviewed the code in `DefaultRealmPullResultHandler`
and found that you were right about removing the additional `after()` calls -
as proposed in #84 .
This because
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/84
That call is *not* redundant, it is invoking the `after()` method with any
defined push actions.
Please close this PR.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
Thanks for your contribution: see it on-line at
https://ci.apache.org/projects/syncope/2_1_X/getting-started.html#kubernetes-sample
As you can see, I did some minor editing and reflow.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
ping @mornindew
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
Thanks @mornindew
Could you please rebase your changes to latest `master` and squash your
commits into one only? Thanks.
And what about ICLA? Did you submit it?
---
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/83#discussion_r214544229
--- Diff: docker/src/main/resources/k8s/helm/README.adoc ---
@@ -0,0 +1,22 @@
+= Install Commands
+
+Open a terminal and navigate to the "
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
Please ensure that all new files contain the correct license header, or
build will fail; for YAML, you can grab it from
https://github.com/apache/syncope/blob/master/docker/src/main/resources
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
Thanks for this PR @mornindew - I'll review it in few days.
Meanwhile: have you already submitted your ICLA?
http://www.apache.org/licenses/#clas
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/81
This PR is for SYNCOPE-1220 (auto-link to JIRA)
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
The results are available at
https://ci.apache.org/projects/syncope/2_1_X/getting-started.html#docker-compose-samples
and will appear at
https://syncope.apache.org/docs/getting-started.html#docker
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
Thanks for quick turnaround :+1:
Please squash your commits and I'll be glad to merge, thanks.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
Thanks for your contribution @pfrenssen !
I've added a couple of comments, please address.
Please also consider [sending an
ICLA](http://syncope.apache.org/contrib
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/80#discussion_r209650421
--- Diff: src/main/asciidoc/getting-started/obtain.adoc ---
@@ -422,6 +422,23 @@ services:
<4> Apache Syncope Enduser UI, port `38080` exposed, w
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/80#discussion_r209648695
--- Diff: src/main/asciidoc/getting-started/obtain.adoc ---
@@ -422,6 +422,23 @@ services:
<4> Apache Syncope Enduser UI, port `38080` exposed, w
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/79
I have seen:
* you opened SYNCOPE-1328 for this PR
* your new commit, which fixes the build
Could you please squash your two commits into one, preserving the text
`SYNCOPE-1328` in
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/79
Hi @noorulrazvi-saal, thanks for this PR!
Before merging, could you please:
1. sign and send an
[ICLA](http://syncope.apache.org/contributing
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/79#discussion_r198392214
--- Diff: core/spring/src/main/resources/security.properties ---
@@ -28,6 +28,9 @@ secretKey=${secretKey}
jwsKey=${jwsKey}
jwtIssuer=ApacheSyncope
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/78
Thanks @loredicola !
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/77
:+1:
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/77
Thanks @slachiewicz I've just merged this PR: please submit an ICLA for
your future contributions:
http://syncope.apache.org/contributing#How_do_I_become_a_contributor_or_a_committer
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/74
Thanks @DimaAy for your changes, they look fine!
Just squash your 3 commits into 1 and I'll gladly merge this PR, thanks.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/74
Other things for Admin Console: adjust modal window title to match the
actual name:
 and deletes next. That way it will only delete the existing
one which results in no toke
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
I would stick with minimal changes, so this PR should only change
`JPAAccessToken`.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
Ok so...
> Are you simply proposing to add such constraint and leave the rest of the
code as is?
e.g. to change again this PR by reverting all changes and adding the UNIQUE
constraint?
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera the only effect of UNIQUE constraint will be that a
validation error is raised whenever a second AccessToken is created with same
owner of an existing one.
Are you simply
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
Ok, let's try this way: please re-introduce the UNIQUE constraint but
rework the whole `AccessTokenDataBinderImpl#create` to comply with the two
invocation scenarios as reported above.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera I don't remember the details, but what I can see from the
source three is that `AccessTokenDataBinderImpl#create` is invoked in two
places:
1.
https://github.com/a
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera the point is that the existence of `replaceFlag` (I did not
realize that at first) is what prevents to enforce the UNIQUE constraint.
---
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181103559
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181103181
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181103053
--- Diff:
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java
---
@@ -34,6 +34,8
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181102107
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100854
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100663
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100023
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181097338
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181096467
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181093676
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181093708
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181091780
--- Diff:
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java
---
@@ -34,6 +34,8
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181089858
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181089640
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181088731
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181088154
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181087678
--- Diff:
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java
---
@@ -34,6 +34,8
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181087221
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181086944
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/69
Thanks @IsurangaPerera I have merged this PR
Did you already send your ICLA?
For your future contributions, please always include the referenced issue
in proper case, e.g. `SYNCOPE-1296
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/commit/7b168c142b09c3b03e39f1449211e7ddf026a14d#commitcomment-28411553
In
common/lib/src/main/java/org/apache/syncope/common/lib/search/SearchableFields.java:
In
common/lib/src/main/java/org
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
@clucgdc are you still interested? If not, please close this PR as I don't
have karma to do that.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
> It seems that not much people use netbeans plugin
Agree, but after SYNCOPE-1220 there should be much many reasons to do that
;-)
Are you still interested in GSoC? Why don't yo
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
Thanks for your contribution @rohanjulka19 !
Sorry it took so long: as you can see, I've squashed your commits before
merging.
Moreover, I've merged the commit to both `master`
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174045249
--- Diff: ide/netbeans/pom.xml ---
@@ -133,7 +133,6 @@ under the License.
false
-
--- End diff
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174040731
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
-
+
--- End diff --
No need
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r173764200
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
-
+
--- End diff --
Please
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
Please add the text `[SYNCOPE-1220]` to your commit's message, to link this
PR's commits to JIRA, thanks.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/67
np
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/67
Please close this PR, I don't see reasons to merge it.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/67
Ah, correct it's .nbm indeed: why on earth you have downloaded as ZIP?
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/67
You don't need to "change its extension", you need to unzip it.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/67
There is no "If the downloaded plugin is in zip format", it *is* in zip
format, please adjust.
Also, wrap the note into an asciidoctor's `[TIP]` block,
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/65
I see your changes now published, cool :-)
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/65
> Can you please tell me when the changes will reflect on the site.
I have already requested your changes to be published, but it seems that
[the ASF CI](https://ci.apache.org/build
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/65
Thanks @rohanjulka19 I have just merged your contribution.
Please consider sending an
[ICLA](http://syncope.apache.org/contributing.html#How_do_I_become_a_contributor_or_a_committer
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/64
Thanks @naofum for your contribution!
I have applied this PR to branches `2_0_X` and `master`, hence Japanese
translation will be available with next releases 2.0.8 and 2.1.0
Shortly
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/64
I have seen you opened SYNCOPE-1259, thanks!
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/64
Ah, I see it's also for Enduser UI, cool! :-)
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/64
You can take https://issues.apache.org/jira/browse/SYNCOPE-828 as reference
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/64
Thanks @naofum! We've been notified of your ICLA submission, please go
ahead and open an issue on
[JIRA](https://issues.apache.org/jira/projects/SYNCOPE) as stated above.
I've s
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
No updates during the last three months: shall we close this PR?
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
Hey @clucgdc any news?
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/63
Thanks @tlnd-fcurvat !
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/63
I have just seen SYNCOPE-1211 thanks!
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/63
Hi @tlnd-fcurvat thanks for this PR.
The fix looks good and I could merge it straight away, but I'd need first a
couple of things:
1. you should submit an
[ICLA]
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
What if you make:
5.1 Working with a database
5.1.1 Configure database resource
5.1.2 Propagate to database resource
5.1.3 Pull from database resource
(and then the same
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135969624
--- Diff: src/main/asciidoc/reference-guide/tutorials/tutorials.adoc ---
@@ -17,9 +17,6 @@
// under the License.
//
== Tutorials
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
Just a few minor changes.
How about my comment above:
> I think that, after Resource configuration, you should also include an
example Pull Task and show an example when users
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135714121
--- Diff: src/main/asciidoc/reference-guide/tutorials/tutorials.adoc ---
@@ -17,9 +17,6 @@
// under the License.
//
== Tutorials
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135712262
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -1,14 +1,7 @@
=== Configure a Database resource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135445658
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/62
Thanks @loredicola!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135191229
--- Diff: src/main/asciidoc/reference-guide/tutorials/tutorials.adoc ---
@@ -0,0 +1,25 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135191006
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135190937
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135190717
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135190610
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/61#discussion_r135190201
--- Diff:
src/main/asciidoc/reference-guide/tutorials/configdatabaseresource.adoc ---
@@ -0,0 +1,160 @@
+=== Configure a Database resource
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
Hi @clucgdc thanks for this PR.
You need to rename all files with JPG (uppercase) extension to jpg
(lowercase), otherwise when building on non-Windows boxes you'll get the
following e
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/60#discussion_r134943352
--- Diff: nbactions.xml ---
@@ -0,0 +1,15 @@
+
--- End diff --
Please do not include this file in the PR.
---
If your project is set up
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/59
Thanks @loredicola for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/56
Thanks again @mat-ale
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/54
LGTM just merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
1 - 100 of 376 matches
Mail list logo
