ilgrosso commented on a change in pull request #258:
URL: https://github.com/apache/syncope/pull/258#discussion_r610533237



##########
File path: 
fit/wa-reference/src/test/java/org/apache/syncope/fit/ui/SAML2SP4UIITCase.java
##########
@@ -156,6 +158,20 @@ public static void idpSetup() {
         saml2sp4UIIdPService.update(cas);
     }
 
+    @Test
+    public void fetchSpMetadata() throws Exception {
+        try (CloseableHttpClient httpclient = HttpClients.createDefault()) {
+            HttpClientContext context = HttpClientContext.create();
+            context.setCookieStore(new BasicCookieStore());
+
+            HttpGet get = new HttpGet(WA_ADDRESS + "/sp/metadata");
+            CloseableHttpResponse response = httpclient.execute(get, context);
+            assertEquals(HttpStatus.SC_OK, 
response.getStatusLine().getStatusCode());
+            String responseBody = EntityUtils.toString(response.getEntity());
+            assertNotNull(responseBody);

Review comment:
       I'd rather change this with
   
   ```
   assertFalse(responseBody.isEmpty());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to