Re: getAdminRolesFilter-query

2015-05-13 Thread Francesco Chicchiriccò
11:06 Uhr Von: "Francesco Chicchiriccò" An: dev@syncope.apache.org Betreff: Re: getAdminRolesFilter-query On 17/04/2015 10:41, Guido Wimmel wrote: Hi Francesco, ok, thanks for the clarification. I can see if I can investigate further and provide a patch. I did run the integration tes

Re: getAdminRolesFilter-query

2015-05-12 Thread Guido Wimmel
e.org > Betreff: Re: getAdminRolesFilter-query > > On 17/04/2015 10:41, Guido Wimmel wrote: > > Hi Francesco, > > > > ok, thanks for the clarification. I can see if I can investigate further > > and provide a patch. > > > > I did run the integration tests but I do not

Re: getAdminRolesFilter-query

2015-04-17 Thread Francesco Chicchiriccò
https://github.com/apache/syncope/blob/1_2_X/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java#L229 Regards. Gesendet: Freitag, 17. April 2015 um 09:05 Uhr Von: "Francesco Chicchiriccò" An: dev@syncope.apache.org Betreff: Re: getAdminRolesFilter-query On 16/

Re: getAdminRolesFilter-query

2015-04-17 Thread Guido Wimmel
owns all entitlements (so nothing is filtered out). Cheers, Guido > Gesendet: Freitag, 17. April 2015 um 09:05 Uhr > Von: "Francesco Chicchiriccò" > An: dev@syncope.apache.org > Betreff: Re: getAdminRolesFilter-query > > On 16/04/2015 21:20, Guido Wimmel wrote: &

Re: getAdminRolesFilter-query

2015-04-17 Thread Francesco Chicchiriccò
On 16/04/2015 21:20, Guido Wimmel wrote: Hi Francesco, I'm only talking about the part of the query generated by SubjectSearchDAOImpl.getAdminRolesFilter(). The FIQL string is not used for generating this part, only type and adminRoles. The part I wrote about is only used when type==SubjectTy

Re: getAdminRolesFilter-query

2015-04-16 Thread Guido Wimmel
Hi Francesco, I'm only talking about the part of the query generated by SubjectSearchDAOImpl.getAdminRolesFilter(). The FIQL string is not used for generating this part, only type and adminRoles. The part I wrote about is only used when type==SubjectType.USER. I was considering if the origina

Re: getAdminRolesFilter-query

2015-04-16 Thread Francesco Chicchiriccò
On 16/04/2015 11:00, Guido Wimmel wrote: Hi, minor detail, but I recently stubled upon the query generated by SubjectSearchDAOImpl.getAdminRolesFilter(), used by search() and count(). Maybe it could be simplified. It seems to determine all users which have roles not in adminRoles (to be able

getAdminRolesFilter-query

2015-04-16 Thread Guido Wimmel
Hi, minor detail, but I recently stubled upon the query generated by SubjectSearchDAOImpl.getAdminRolesFilter(), used by search() and count(). Maybe it could be simplified. It seems to determine all users which have roles not in adminRoles (to be able to filter them out by WHERE subject_id NOT