Re: Sandbox not building - compilation errors/ work in progress?

2017-10-01 Thread Anatole Tresch
Some commits were not yet pushed when I was on the way ;-) It looks good now, see https://builds.apache.org/job/Tamaya-Sandbox-Master/964 [INFO] Reactor Summary: [INFO] [INFO] Apache Tamaya Modules - Collections Support SUCCESS [ 48.803 s] [INFO] Apache Tamaya Sandbox ...

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187567#comment-16187567 ] ASF subversion and git services commented on TAMAYA-300: Commit 3b

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187566#comment-16187566 ] ASF subversion and git services commented on TAMAYA-300: Commit 22

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187563#comment-16187563 ] ASF subversion and git services commented on TAMAYA-300: Commit 9f

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187558#comment-16187558 ] ASF subversion and git services commented on TAMAYA-300: Commit 82

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187559#comment-16187559 ] ASF subversion and git services commented on TAMAYA-300: Commit 03

[jira] [Commented] (TAMAYA-291) Ensure a unit test coverage of at least 50% for Tamaya Extensions

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187548#comment-16187548 ] ASF subversion and git services commented on TAMAYA-291: Commit f7

Sandbox not building - compilation errors/ work in progress?

2017-10-01 Thread P. Ottlinger
Hi, after spotting a licensing issue in sandbox I realized that the modules do not seem to build right now. Is there a feature branch with fixes available/locally? https://builds.apache.org/view/S-Z/view/Tamaya/job/Tamaya-Sandbox-Master/960/console Cheers, Phil

Re: Anyone looking at this PR?

2017-10-01 Thread P. Ottlinger
Am 30.09.2017 um 23:13 schrieb Anatole Tresch: > I shortly looked at it. It makes sense, so +1 to merge from my side... I'm unable to accept the PR not sure if it's a bug with the Github-integration, but +1 from me. Phil

[jira] [Commented] (TAMAYA-200) Document how to control the output of the banner

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187535#comment-16187535 ] ASF subversion and git services commented on TAMAYA-200: Commit b8

[jira] [Commented] (TAMAYA-291) Ensure a unit test coverage of at least 50% for Tamaya Extensions

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187520#comment-16187520 ] ASF subversion and git services commented on TAMAYA-291: Commit 22

Re: Implementation for CDIConfiguredMethod#getSignature()

2017-10-01 Thread Anatole Tresch
Well, not sure. basically it would be a good thing to have it globally unique, so an example would be: java.lang.String my.fully.qualified.ClassName#getName(); boolean my.fully.qualified.ClassName#isPropertySet(java.lang.String); or with inner classes: boolean my.fully.qualified.ClassName$

Re: Handling Optional in Tamaya core?

2017-10-01 Thread P. Ottlinger
Am 01.10.2017 um 16:15 schrieb Oliver B. Fischer: > Hm, looking at the code now I think you are right that is doesn't make > such sense. Thanks for all of your opinions - I was opposed to the optional stuff because I try to see it from a semantic point of view. What is an optional-empty configura

Re: MASTER BUILD BROKEN BECAUSE OF COVERAGE

2017-10-01 Thread P. Ottlinger
Am 01.10.2017 um 19:04 schrieb John D. Ament: > So it can be run but its not default. Do we have this info in a readme? > Should it become default? I'd prefer it to be default - we could raise the bar once we reach a reasonable level Just my 2ct Phil

Re: MASTER BUILD BROKEN BECAUSE OF COVERAGE

2017-10-01 Thread John D. Ament
So it can be run but its not default. Do we have this info in a readme? Should it become default? On Oct 1, 2017 12:56 PM, "Oliver B. Fischer" wrote: > You can run it locally via mvn -P coverage > > The generated reports can be found under target/pit-reports/ > > > Am 01.10.17 um 17:50 schr

Re: MASTER BUILD BROKEN BECAUSE OF COVERAGE

2017-10-01 Thread Oliver B. Fischer
You can run it locally via mvn -P coverage The generated reports can be found under target/pit-reports/ Am 01.10.17 um 17:50 schrieb John D. Ament: Does the profile that check for code coverage run locally? or can it only run in jenkins? On Sun, Oct 1, 2017 at 9:21 AM Oliver B. Fischer

Re: MASTER BUILD BROKEN BECAUSE OF COVERAGE

2017-10-01 Thread John D. Ament
Does the profile that check for code coverage run locally? or can it only run in jenkins? On Sun, Oct 1, 2017 at 9:21 AM Oliver B. Fischer wrote: > Dear all, > > the test coverage of Tamya went down from 52 to 51 after merging the > Java 8 branch to master. I woulk like to ask the authors who co

Re: Implementation for CDIConfiguredMethod#getSignature()

2017-10-01 Thread Oliver B. Fischer
So the return value should not contain package and class? I will add the missing implementation. Thank you Anatole! Oliver Am 29.09.17 um 11:14 schrieb Anatole Tresch: No ;-), it should return something like: (*) J Anatole 2017-09-29 9:05 GMT+02:00 Oliver B. Fischer : Hi Anatole, cou

Re: Handling Optional in Tamaya core?

2017-10-01 Thread Oliver B. Fischer
Hm, looking at the code now I think you are right that is doesn't make such sense. Oliver Am 29.09.17 um 14:36 schrieb John D. Ament: I'm not sure I got that 100% but replicating the API only made sense when you were not targetting the Java 8 runtime. Now that Java 8 is the minimum why not

[jira] [Commented] (TAMAYA-291) Ensure a unit test coverage of at least 50% for Tamaya Extensions

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187384#comment-16187384 ] ASF subversion and git services commented on TAMAYA-291: Commit 9b

MASTER BUILD BROKEN BECAUSE OF COVERAGE

2017-10-01 Thread Oliver B. Fischer
Dear all, the test coverage of Tamya went down from 52 to 51 after merging the Java 8 branch to master. I woulk like to ask the authors who contributed to the Java 8 branch to check for missing tests. Oliver -- N Oliver B. Fischer A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany P +

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187351#comment-16187351 ] ASF subversion and git services commented on TAMAYA-300: Commit c9

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187352#comment-16187352 ] ASF subversion and git services commented on TAMAYA-300: Commit b1

[jira] [Commented] (TAMAYA-300) Provide a Tamaya integration module for OSGI ConfigAdmin

2017-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187350#comment-16187350 ] ASF subversion and git services commented on TAMAYA-300: Commit 9d