[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687710#comment-16687710 ] ASF GitHub Bot commented on TAMAYA-358: --- GitHub user peculater opened a pull reques

[GitHub] incubator-tamaya-extensions pull request #12: TAMAYA-358 Get CDI working wit...

2018-11-15 Thread peculater
GitHub user peculater opened a pull request: https://github.com/apache/incubator-tamaya-extensions/pull/12 TAMAYA-358 Get CDI working with optional configvalues There are two use cases in here, both related to injected config values that are not required. First, the "requir

[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688301#comment-16688301 ] ASF GitHub Bot commented on TAMAYA-358: --- Github user ajs6f commented on the issue:

[GitHub] incubator-tamaya-extensions issue #12: TAMAYA-358 Get CDI working with optio...

2018-11-15 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/12 Hi, having filed TAMAYA-358, I'd like to test this PR. One quick question: am I correct to think that the right idiom for config with no default value is as shown (from the tests)

[GitHub] incubator-tamaya-extensions issue #12: TAMAYA-358 Get CDI working with optio...

2018-11-15 Thread peculater
Github user peculater commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/12 For that use I'd go with ``` @Inject @Config private Optional myConfigVal; ``` The default config name is the name of the variable, and "required=(true|fa

[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688381#comment-16688381 ] ASF GitHub Bot commented on TAMAYA-358: --- Github user peculater commented on the iss

[GitHub] incubator-tamaya-extensions issue #12: TAMAYA-358 Get CDI working with optio...

2018-11-15 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/12 Woo-hoo! I can confirm that ``` @Inject @Config private Optional myConfigVal; ``` works, and so (not surprisingly) does: ``` @Inject @Config(value

[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688520#comment-16688520 ] ASF GitHub Bot commented on TAMAYA-358: --- Github user ajs6f commented on the issue:

[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread Anatole Tresch (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688834#comment-16688834 ] Anatole Tresch commented on TAMAYA-358: --- I added a possible fix on the current head

[jira] [Commented] (TAMAYA-358) No way to inject an optional config value via CDI

2018-11-15 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688858#comment-16688858 ] A. Soroka commented on TAMAYA-358: -- Hello, [~anatole], I'm probably missing something ob