Am 17.01.19 um 17:02 schrieb Aaron Coburn:
> What would you all think about adjusting the maven configuration to have
> checkstyle run on each build? Initially, it might make sense to just report
> the errors rather than failing an entire build because of them. I can supply
> a PR for this.
coo
Am 17.01.19 um 21:09 schrieb Aaron Coburn:
> I've noticed that for any Github activity on tamaya-extensions and
> tamaya-sandbox (pull requests, comments, etc), messages are sent to the dev@
> list, but that doesn't seem to apply to activity on the main tamaya
> repository. Is there a missing pa
acoburn commented on issue #26: TAMAYA-219: Enable checkstyle analysis
URL:
https://github.com/apache/incubator-tamaya-extensions/pull/26#issuecomment-455324004
I now realize that this PR is going to fail because the
`buildconfigurations` artifact from the main codebase is pushed neither t
Hi All,
I've noticed that for any Github activity on tamaya-extensions and
tamaya-sandbox (pull requests, comments, etc), messages are sent to the dev@
list, but that doesn't seem to apply to activity on the main tamaya repository.
Is there a missing part of the integration? Maybe something for
acoburn opened a new pull request #18: TAMAYA-219: Enable checkstyle analysis
URL: https://github.com/apache/incubator-tamaya-sandbox/pull/18
This enables checkstyle analysis of the sandbox modules
but will not (at present) fail builds on style violations.
---
acoburn opened a new pull request #26: TAMAYA-219: Enable checkstyle analysis
URL: https://github.com/apache/incubator-tamaya-extensions/pull/26
This enables checkstyle analysis on the extension modules. Errors will be
reported to the console but will not (at present) fail a build.
---
Thanks for the review. With these changes now in place, I started looking at
adjusting the checkstyle rules to enforce (or at least prevent the use of JUnit
assertions), but it seems that the checkstyle configuration isn't run on a
typical `mvn clean verify` or `mvn clean install`. As it is, the
